Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add predefined widths to the Sidebar #1300

Conversation

haideralsh
Copy link
Contributor

@haideralsh haideralsh commented Oct 31, 2023

Description

  • Allow passing a predefined width ("xs", "s", "m", "l", "xl") when using the Sidebar while preserving the ability to pass any other valid width value.
  • Add a helpText and a renderHelpText props to the Sidebar component.

Linked issues

Fixes #1293

Changes include

  • breaking change: a change that is not backwards-compatible and/or changes current functionality
  • fix: a non-breaking change that solves an issue
  • feature: a non-breaking change that adds functionality
  • chore: contains no changes affecting the library, such as documentation or test updates

Feature checklist

  • Appropriate tests have been added
  • Documentation has been updated
  • Accessibility has been considered

@haideralsh haideralsh linked an issue Oct 31, 2023 that may be closed by this pull request
4 tasks
Allow passing a predefined width ("xs", "s", "m", "l", "xl") when using
the Sidebar while preserving the ability to pass any other valid width
value.
@haideralsh haideralsh force-pushed the 1293-adding-description-and-different-widths-to-sidebar-component branch from c9d6e77 to 57275a4 Compare October 31, 2023 21:45
- Add a helpText and a renderHelpText props to the Sidebar component.
@haideralsh haideralsh force-pushed the 1293-adding-description-and-different-widths-to-sidebar-component branch from 57275a4 to 4fea433 Compare November 1, 2023 15:04
@haideralsh haideralsh merged commit 4295135 into master Nov 1, 2023
2 checks passed
@haideralsh haideralsh deleted the 1293-adding-description-and-different-widths-to-sidebar-component branch November 1, 2023 15:48
Copy link

github-actions bot commented Nov 1, 2023

🎉 This PR is included in version 8.16.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Adding description and different widths to Sidebar component
1 participant