Fix missing props and value #1335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jherdman
commented
Dec 13, 2023
Comment on lines
+19
to
+25
| const renderHeaderCellContent = ({ | ||
| headerFormatter = defaultheaderFormatter, | ||
| align, | ||
| label, | ||
| dataKey, | ||
| width, | ||
| }: ColumnType) => headerFormatter({ align, label, dataKey, width }); |
There was a problem hiding this comment.
This is possibly a breaking change, but it complies with the type described in Table.types.ts.
haideralsh
approved these changes
Dec 13, 2023
`index` was undefined
haideralsh
force-pushed
the
fix-missing-props-and-value
branch
from
4bd57c2 to
1f41bad
Compare
This doesn't attempt to solve all type problems here. Removing the TS opt out reveals further problems that will be resolved later.
BREAKING CHANGE: only properties conforming to the ColumnType are passed as props to the headerFormatter.
haideralsh
force-pushed
the
fix-missing-props-and-value
branch
from
1f41bad to
cafdf31
Compare
|
🎉 This PR is included in version 9.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
ECO ran into a few problems with the
TableHeadcomponent when upgrading. This pull request includes the necessary fix ("Fix missing argument" commit), and resolves the type woes for the aforementioned file.Changes include
Feature checklist