Improve Pagination Types #1421
Merged
Improve Pagination Types #1421
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous iteration of these type was accounting for the generated page numbers being either a string (`SEPARATOR`) or numbers. In this commit I introduce a much narrower type for the `getPageItemsToDisplay` function. In doing so we more closely map to the reality of the implementation and can use a more appropriately narrow type for `onSelectPage`. This resolves some challenges with ECO.
haideralsh
approved these changes
Jun 3, 2024
haideralsh
approved these changes
Jun 3, 2024
|
🎉 This PR is included in version 10.2.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The previous iteration of these type was accounting for the generated
page numbers being either a string (
SEPARATOR) or numbers.In this commit I introduce a much narrower type for the
getPageItemsToDisplayfunction. In doing so we more closely map to thereality of the implementation and can use a more appropriately narrow
type for
onSelectPage.This resolves some challenges with ECO.
Changes include
Feature checklist