fix: types for React 18 #1422
Merged
fix: types for React 18 #1422
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haideralsh
commented
May 28, 2024
| @@ -28,7 +28,7 @@ const RangeContainer: React.FC<RangeContainerProps> = ({ | |||
| const restProps = omitSubset(props, propTypes.space); | |||
|
|
|||
| return ( | |||
| <Flex {...spaceProps} flexDirection="column"> | |||
| (<Flex {...spaceProps} flexDirection="column"> | |||
There was a problem hiding this comment.
Seems like an unintended change
haideralsh
commented
May 28, 2024
src/NavBar/NavBar.tsx
Outdated
| @@ -208,7 +208,7 @@ const SelectNavBarBasedOnWidth = ({ width, defaultOpen, breakpointUpper, ...prop | |||
| } else { | |||
| return ( | |||
| // @ts-ignore | |||
| <SmallNavBar {...props} width={currentWidth} defaultOpen={defaultOpen} /> | |||
| (<SmallNavBar {...props} width={currentWidth} defaultOpen={defaultOpen} />) | |||
There was a problem hiding this comment.
Unintended change
haideralsh
commented
May 28, 2024
| const { colors } = useTheme(); | ||
|
|
||
| const color1 = inactive ? colors.grey : colors.blue; | ||
| const color2 = inactive ? colors.lightGrey : colors.yellow; | ||
|
|
||
| return ( | ||
| // Modified svg By Sam Herbert (@sherb), for everyone. More @ http://goo.gl/7AJzbL | ||
| <svg | ||
| (<svg |
There was a problem hiding this comment.
Unintended change
haideralsh
force-pushed
the
fix-types-for-react-18
branch
from
1cc12ca to
5af6663
Compare
Result of running: npx types-react-codemod preset-18 ./src Pick transforms to apply (Press <space> to select, <a> to toggle all, <i> to invert selection, and <enter> to proceed) ◯ context-any ◉ deprecated-react-type ◉ deprecated-sfc-element ◉ deprecated-sfc ◉ deprecated-stateless-component ◉ implicit-children ◯ useCallback-implicit-any
haideralsh
force-pushed
the
fix-types-for-react-18
branch
from
5af6663 to
139e8f5
Compare
|
🎉 This PR is included in version 10.2.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Result of running:
Changes include
Feature checklist