fix: remove defaultProps and propTypes #1434
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
haideralsh
force-pushed
the
remove-defaultProps-propTypes
branch
from
6e75771 to
fd79f06
Compare
haideralsh
force-pushed
the
remove-defaultProps-propTypes
branch
2 times, most recently
from
38a434c to
120c9d5
Compare
haideralsh
force-pushed
the
remove-defaultProps-propTypes
branch
from
120c9d5 to
0533de2
Compare
haideralsh
commented
Sep 10, 2024
src/List/ListItem.tsx
Outdated
|
|
||
| type Props = React.ComponentPropsWithRef<"li"> & SpaceProps & ColorProps & TypographyProps; | ||
|
|
||
| const ListItem = styled.li<Props>(space, color, typography, { |
There was a problem hiding this comment.
Missing DefaultProps
src/Tooltip/Tooltip.tsx
Outdated
| @@ -26,8 +26,20 @@ export type TooltipProps = { | |||
| children?: React.ReactNode; | |||
| }; | |||
|
|
|||
| const Tooltip: React.FC<React.PropsWithChildren<TooltipProps>> = React.forwardRef( | |||
| ({ className, tooltip, maxWidth, children, placement, showDelay, hideDelay, defaultOpen }, ref) => ( | |||
| const Tooltip = React.forwardRef<any, TooltipProps>( | |||
There was a problem hiding this comment.
Replace any with ref type
haideralsh
force-pushed
the
remove-defaultProps-propTypes
branch
from
cb645c2 to
8214212
Compare
haideralsh
changed the title
haideralsh
changed the title
haideralsh
force-pushed
the
remove-defaultProps-propTypes
branch
from
8214212 to
86c6f5e
Compare
github-actions bot
pushed a commit
that referenced
this pull request
Sep 10, 2024
## [10.2.11](v10.2.10...v10.2.11) (2024-09-10) ### Bug Fixes * remove defaultProps and propTypes ([#1434](#1434)) ([c38bfc6](c38bfc6))
|
🎉 This PR is included in version 10.2.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixes: #1433
Changes include
Feature checklist