Add a touch variant #1468
Merged
Add a touch variant #1468
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BREAKING CHANGE: changes NDSProvider `size` prop to `variant`. The `size` prop was originally used sparingly in some components like the Button and the Icon to resize those components. It was later extended to make all interactive components large enough to be used on a touch screen, through changing the `size` prop directly or by passing a `size` prop to the NDSProvider globally. With this change, we retain the use of the `size` prop for select components, and introduce a `variant` prop that can be passed either to individual components or the NDSProvider globally with the value of either `desktop` or `touch`.
haideralsh
force-pushed
the
add-a-touch-variant
branch
from
82fda70 to
62987ca
Compare
haideralsh
force-pushed
the
add-a-touch-variant
branch
from
7db895b to
d5767a2
Compare
haideralsh
force-pushed
the
add-a-touch-variant
branch
from
9100a79 to
cc35d4b
Compare
haideralsh
force-pushed
the
add-a-touch-variant
branch
3 times, most recently
from
754f1e9 to
be3c170
Compare
BREAKING CHANGE: removes the `icon` and `iconSize` props from the input in-favor of `iconLeft`, `iconRight`, `iconRightSize`, `iconLeftSize` Migration: * Replace `icon` prop with `iconRight` * Replace `iconSize` prop with `iconRightSize`
BREAKING CHANGE: removes the old unused NavBar component that was replaced with the BrandedNavBar
The configuration panel requires duplicating logic of the NDSProvider and can cause unwanted bugs.
* Use numbers for fontWeights * Double the size coefficient
haideralsh
force-pushed
the
add-a-touch-variant
branch
from
be3c170 to
f9cfa64
Compare
haideralsh
commented
Nov 7, 2024
| export const AlertTypes = () => ( | ||
| <Flex flexDirection="column" gap="x1"> | ||
| {" "} |
There was a problem hiding this comment.
Remove in next version
|
🎉 This PR is included in version 11.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BREAKING CHANGE: changes NDSProvider
sizeprop tovariant.The
sizeprop was originally used sparingly in some components like theButton and the Icon to resize those components.
It was later extended to make all interactive components large enough to
be used on a touch screen, through changing the
sizeprop directly orby passing a
sizeprop to the NDSProvider globally.With this change, we retain the use of the
sizeprop for selectcomponents, and introduce a
variantprop that can be passed either toindividual components or the NDSProvider globally with the value of
either
desktoportouch.Changes include
Feature checklist