Skip to content

Conversation

@vaibhavtiwari33
Copy link
Contributor

@vaibhavtiwari33 vaibhavtiwari33 commented Nov 6, 2025

What this PR does / why we need it

As part of completing testing for the on-success sink feature, we want to add an end-2-end test which creates a pipeline with on-success UD sink and validates the messages being written to it.
This PR aims to add this test and the manifest which the test uses to create the said pipeline as well as perform a basic validation based on the testing blueprint for fallback sink.

Related issues

Closes: #3046

Testing

This is the test

Special notes for reviewers

Blocker

Requires release of the next version of any one of the SDKs to successfully work.
Currently built go-sdk image with on-success sink changes, used in the manifest, fails to come up due to version restriction imposed in numaflow-core:
SDK version 0.10.1 must be upgraded to at least 0.10.2, in order to work with the current numaflow version

Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
@codecov
Copy link

codecov bot commented Nov 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.75%. Comparing base (74885f5) to head (7de8a67).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #3067   +/-   ##
=======================================
  Coverage   79.75%   79.75%           
=======================================
  Files         291      291           
  Lines       65044    65044           
=======================================
+ Hits        51878    51879    +1     
+ Misses      12614    12613    -1     
  Partials      552      552           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Signed-off-by: Vaibhav Tiwari <vaibhav.tiwari33@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/sink testing Testing and CI

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E Tests to cover onSuccess Sink

2 participants