Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic dark mode support:
numberscope.dark.mode.mov
I replaced
--ns-color-whitewith--ns-color-bgwhen used as a background color, andns-color-blackto--ns-color-fgwhen used as a text color. Other uses of these variables (e.g. borders) remain intactUses the
light-dark()function. This has 87% browser support compared to 96% support forprefers-color-scheme, but has the advantage of colocating the variants; if desired, I can change it to useprefers-color-schemeinstead.the SVG text also changes color
I didn't provide a dark variant for
--ns-color-primarysince it's the brand color and I don't know if it needs to align with other things