fix: Use path.sep for cross-platform path validation #18
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replaced hardcoded forward slash '/' with path.sep in security checks to ensure correct path validation on Windows. This resolves the "Security error: Installation path outside target directory" issue when installing skills on Windows.
|
Tested on Windows - this fix works! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix: Use path.sep for cross-platform path validation
This PR fixes a security check failure on Windows when installing skills.
The previous implementation used a hardcoded forward slash (
/) to validate that the installation path is within the target directory. On Windows,path.resolvereturns paths with backslashes (\), causing thestartsWithcheck to fail and triggering the error:Security error: Installation path outside target directory.Changes
'/'withpath.sepin src/commands/install.ts to ensure compatibility with the OS-specific path separator.Related Issue
#17
Verification
openskills install <skill>on a Windows machine.