Harden install path validation with filesystem-aware checks and cross-platform security tests #26
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR refactors path validation to use
path.relative()and fixesWindows compatibility issues.
Problem
The original validation logic had two issues:
Windows incompatibility: Hardcoded '/' separator caused false
rejections of valid installs on Windows
Code clarity: String-based
startsWith()check is less clearthan filesystem-aware
path.relative()Non-issue: Path Traversal
The existing code is already safe from path traversal attacks because:
basename()which strips../join(targetDir, basename(...))The tests added in this PR demonstrate hypothetical attack scenarios
if the code were written differently, but these scenarios don't
reflect actual exploitable vulnerabilities in the current implementation.
Solution
Use
path.relative()for clearer intent and cross-platform compatibility:Impact