Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecate mkApp in favor of direct definitions #103

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

deprecate mkApp in favor of direct definitions #103

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
704e113
deprecate `mkApp` in favor of direct definitions
soupglasses Aug 20, 2023
bee7b40
Update README.md
zimbatm Aug 20, 2023
015b2db
Update examples/each-system/flake.nix
zimbatm Aug 20, 2023
94e7512
deprecate drv.passthru.exePath instead
zimbatm Aug 23, 2023
e54db8d
fix README
zimbatm Aug 23, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,10 @@ eachSystem allSystems (system: { hello = 42; })
default = hello;
};
apps = rec {
hello = flake-utils.lib.mkApp { drv = self.packages.${system}.hello; };
hello = {
type = "app";
program = "${nixpkgs.lib.getExe self.packages.${system}.hello}";
};
default = hello;
};
zimbatm marked this conversation as resolved.
Show resolved Hide resolved
}
Expand All @@ -121,6 +124,12 @@ manageable parts.

### `mkApp { drv, name ? drv.pname or drv.name, exePath ? drv.passthru.exePath or "/bin/${name}"`

> **DEPRECATED**
>
> `mkApp` has been deprecated in favor of direct definitions.
>
> Example: `{ type = "app"; program = "${nixpkgs.lib.getExe drv}"; }`
zimbatm marked this conversation as resolved.
Show resolved Hide resolved

A small utility that builds the structure expected by the special `apps` and `defaultApp` prefixes.


Expand Down
5 changes: 4 additions & 1 deletion examples/each-system/flake.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@
default = hello;
};
apps = rec {
hello = flake-utils.lib.mkApp { drv = self.packages.${system}.hello; };
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't you think it would be nicer to deprecate drv.passthru.exePath and use nixpkgs.lib.getExe in the helper instead?

This is still a bit simpler to use.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That being said, I don't see a lot of value in definining those apps.

Copy link
Author

@soupglasses soupglasses Aug 20, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah. There is a problem where all these apps can be rewritten as packages."<system>"."<name>" since nix3-run runs against meta.mainProgram as well.

Unsure how to show examples without removing apps outright.

hello = {
type = "app";
program = "${nixpkgs.lib.getExe self.packages.${system}.hello}";
zimbatm marked this conversation as resolved.
Show resolved Hide resolved
};
default = hello;
};
}
Expand Down
10 changes: 9 additions & 1 deletion lib.nix
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -202,11 +202,19 @@ let
recursiveUpdate output (import subflake inputs)) { };

# Returns the structure used by `nix app`
mkApp =
mkApp = let
# Pulled from nixpkgs.lib
warn =
if builtins.elem (builtins.getEnv "NIX_ABORT_ON_WARN") ["1" "true" "yes"]
then msg: builtins.trace "warning: ${msg}" (abort "NIX_ABORT_ON_WARN=true; warnings are treated as unrecoverable errors.")
else msg: builtins.trace "warning: ${msg}";
in
{ drv
, name ? drv.pname or drv.name
, exePath ? drv.passthru.exePath or "/bin/${name}"
}:
warn
"`mkApp` has been deprecated in favor of direct definitions. Replace definitions of `mkApp { drv = ...; }` with `{ type = \"app\"; program = \"\${nixpkgs.lib.getExe drv}\"; }`, and definitions of `mkApp { drv = ...; name = \"abc\"; }` with `{ type = \"app\"; program = \"\${drv}/bin/abc\"; }` to remove this warning. Use of `passthru.exePath` inside derivations should be replaced with nixpkgs's `meta.mainProgram` instead."
zimbatm marked this conversation as resolved.
Show resolved Hide resolved
{
type = "app";
program = "${drv}${exePath}";
Expand Down