Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simple, more elegant implementation of setting uid/gid on copied files #191

Merged
merged 1 commit into from
Feb 3, 2025

Conversation

srd424
Copy link
Contributor

@srd424 srd424 commented Jan 29, 2025

Simple implementation of setting uid/gid on copied files, more elegant error handing-wise than previous version.

This still does not yet look up user or group names, but it's useful enough to merge I think?

Partial fix for #190.

@zimbatm zimbatm requested a review from r-vdp January 30, 2025 10:04
@r-vdp r-vdp merged commit de28d23 into numtide:main Feb 3, 2025
20 checks passed
@r-vdp
Copy link
Member

r-vdp commented Feb 3, 2025

Thanks!

For the user resolution we can use https://docs.rs/nix/latest/nix/unistd/struct.User.html#method.from_name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants