Conversation
jfly
left a comment
jfly
left a comment
There was a problem hiding this comment.
Very nice, thanks. I just don't know what our policy is around how far backwards compatible we strive to be with nixpkgs.
Has NixOS/nixpkgs#476453 been backported to nixos 25.11?
| default = true; | ||
| example = false; | ||
| }; | ||
| schema = l.mkOption { |
There was a problem hiding this comment.
Is there any value in keeping this schema option around now?
There was a problem hiding this comment.
I don't even know what the actual reason for this option, existing. I will give this about 24 hours for someone to respond a actual reason about this option should exist, before I go ahead and remove this in this pr.
It hasn't, but i don't mind if you go ahead and backport it. |
@brianmcgee, if @Eveeifyeve's PR adding the schema output were backported to nixos 25.11, would this PR be acceptable for merging? Or would we rather wait longer than that? |
I am just going to backport this anyways, it doesn't hurt to NixOS/nixpkgs#496781 |
2 participants
This pr uses the schema output that was introduced in: NixOS/nixpkgs#476453 instead of
fetchurl.I also updated nixpkgs in flake.lock due to it being outdated and not working if it's not there.
The development of this feature was supported by DigitalBrewStudios.