Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add my personal site to users.json #836

Merged
merged 2 commits into from
Jul 20, 2023
Merged

Add my personal site to users.json #836

merged 2 commits into from
Jul 20, 2023

Conversation

JahsehJ
Copy link
Contributor

@JahsehJ JahsehJ commented Jul 19, 2023

<3 your great works!

@JahsehJ JahsehJ changed the base branch from main to dev July 20, 2023 06:35
@nunocoracao nunocoracao merged commit 0e577e2 into nunocoracao:dev Jul 20, 2023
2 checks passed
@JahsehJ
Copy link
Contributor Author

JahsehJ commented Jul 21, 2023

It seems like my original commit was overwritten by other's 😂

@JahsehJ
Copy link
Contributor Author

JahsehJ commented Jul 21, 2023

@nunocoracao do I reopen PR or you will just fix it? Many thanks 👍

@JahsehJ JahsehJ deleted the patch-1 branch July 21, 2023 08:08
@nunocoracao
Copy link
Owner

Man... my bad... sorry there was conflicts and I f'd up. Send me the details here and I'll add it myself if you prefer. Otherwise yes you can open a new PR.

@JahsehJ
Copy link
Contributor Author

JahsehJ commented Jul 21, 2023

It's all good mate! I'll open a new PR later to save you some time.

@nunocoracao
Copy link
Owner

No need mate I got you - doing a patch release for this plus a couple of updates

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants