Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: additional resources during configuration #27

Merged
merged 5 commits into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 17 additions & 17 deletions aws-ecs/.terraform.lock.hcl

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 2 additions & 0 deletions aws-ecs/outputs.tf
Original file line number Diff line number Diff line change
Expand Up @@ -33,6 +33,8 @@ output "vpc" {

default_security_group_id = aws_security_group.runner.id
# default_security_group_arn = aws_security_group.runner.arn
db_subnet_group_name = module.vpc.database_subnet_group_name
db_subnet_group_id = module.vpc.database_subnet_group
}
}

Expand Down
5 changes: 0 additions & 5 deletions aws-ecs/variables.tf
Original file line number Diff line number Diff line change
Expand Up @@ -38,11 +38,6 @@ variable "tags" {
variable "region" {
type = string
description = "The region to launch the cluster in"

validation {
condition = contains(["us-east-1", "us-east-2", "us-west-1", "us-west-2", ], var.region)
error_message = "${var.region} is currently unsupported"
}
}

// NOTE: if you would like to create an internal load balancer, with TLS, you will have to use the public domain.
Expand Down
4 changes: 2 additions & 2 deletions aws-ecs/vpc.tf
Original file line number Diff line number Diff line change
Expand Up @@ -30,8 +30,8 @@ module "vpc" {
enable_nat_gateway = true
single_nat_gateway = true
enable_dns_hostnames = true
#TODO(jm): these might be breaking installs
#create_database_subnet_group = true

create_database_subnet_group = true
#create_elasticache_subnet_group = true

public_subnet_tags = {
Expand Down
1 change: 1 addition & 0 deletions aws-eks/artifacts/deprovision.json
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,7 @@
"ec2:DeleteRouteTable",
"ec2:DeleteSubnet",
"ec2:DeleteTags",
"ec2:DeleteNetworkAclEntry",
"ec2:DescribeAddresses",
"ec2:DescribeInternetGateways",
"ec2:DescribeLaunchTemplateVersions",
Expand Down
Loading