-
Notifications
You must be signed in to change notification settings - Fork 192
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[T3A2][F11-A1]Anshul Aggarwal #1699
base: master
Are you sure you want to change the base?
Commits on Aug 30, 2016
-
Update regex for better Name matching
Fix comment in Address.java (initially it was email for address) update tests to validate: new name regex
Configuration menu - View commit details
-
Copy full SHA for db3978d - Browse repository at this point
Copy the full SHA db3978dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 730ea58 - Browse repository at this point
Copy the full SHA 730ea58View commit details
Commits on Oct 5, 2016
-
Configuration menu - View commit details
-
Copy full SHA for c3ac0d5 - Browse repository at this point
Copy the full SHA c3ac0d5View commit details -
add more tests to check for dash, dot, qote and unicode characters in…
… the name update expected.txt to reflect the new changes
Configuration menu - View commit details
-
Copy full SHA for cec9204 - Browse repository at this point
Copy the full SHA cec9204View commit details -
fixed regex to "^[\\p{L}0-9 .'-]+$", the prev one did not have numbers
hence any name with numeric characer would be rejected.
Configuration menu - View commit details
-
Copy full SHA for adef5c6 - Browse repository at this point
Copy the full SHA adef5c6View commit details -
Configuration menu - View commit details
-
Copy full SHA for bf7f6bc - Browse repository at this point
Copy the full SHA bf7f6bcView commit details
Commits on Oct 6, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 8928fef - Browse repository at this point
Copy the full SHA 8928fefView commit details
Commits on Oct 20, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 02b59fc - Browse repository at this point
Copy the full SHA 02b59fcView commit details
Commits on Oct 21, 2016
-
Configuration menu - View commit details
-
Copy full SHA for c61e65b - Browse repository at this point
Copy the full SHA c61e65bView commit details
Commits on Nov 27, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 2283852 - Browse repository at this point
Copy the full SHA 2283852View commit details
Commits on Dec 7, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 43c506d - Browse repository at this point
Copy the full SHA 43c506dView commit details
Commits on Dec 8, 2016
-
Configuration menu - View commit details
-
Copy full SHA for 7518552 - Browse repository at this point
Copy the full SHA 7518552View commit details
Commits on Dec 10, 2016
-
Configuration menu - View commit details
-
Copy full SHA for f196968 - Browse repository at this point
Copy the full SHA f196968View commit details
Commits on Dec 11, 2016
-
[nus-cs2103-AY1617S2#108] Add unit tests for AddCommand class (nus-cs…
…2103-AY1617S2#118) * [nus-cs2103-AY1617S2#108] add unit tests for add command * renamed methods for consistency * capitalize todo
Configuration menu - View commit details
-
Copy full SHA for 88133a6 - Browse repository at this point
Copy the full SHA 88133a6View commit details
Commits on Dec 13, 2016
-
[nus-cs2103-AY1617S2#124] Fix code style violation (nus-cs2103-AY1617…
…S2#125) * Fix code style violation reported by checkstyle * Fix checkstyle issues in AddCommandTest
Configuration menu - View commit details
-
Copy full SHA for 7d1de69 - Browse repository at this point
Copy the full SHA 7d1de69View commit details
Commits on Dec 22, 2016
-
[nus-cs2103-AY1617S2#107] Add unit tests for Utils class (nus-cs2103-…
…AY1617S2#127) * Add unit test for Utils class * Reduce the number of test cases in isAnyNull method * Reduce number of test cases in elementsAreUnique method * Change assertAreUnique and assertNotUnique methods to private and remove extra spaces * Remove @before * Remove try catch clause * Inline buildTag method * Change test tag to local variable * Remove unused import * Extract createList() method and remove arraylist * Remove constant * Rearrange test cases to avoid confusion * Rename variable * add test cases to prevent false negative * Inline createList method * Rearrange test cases and remove whitespaces * Add newline at eof * Added spaces for type casting * Update comment for UtilsTest
Configuration menu - View commit details
-
Copy full SHA for 1a15e66 - Browse repository at this point
Copy the full SHA 1a15e66View commit details
Commits on Dec 28, 2016
-
[nus-cs2103-AY1617S2#104] Add unit tests for StorageFile class (nus-c…
…s2103-AY1617S2#128) * Add unit test for StorageFile class * Change indentation and add comments * Make invalid data file more obvious * Create Utility method getStorage * Change contains method to equals method * Style change in StorageFileTest * Style changes in StorageFileTest * Inline getStorage method * Remove unused import * Revert "Inline getStorage method" This reverts commit f431d12. * Re-adjust getStorage() method * Change assertTrue() to assertEquals * Move test files to correct folder * Add test persons and extract to a method * Rework assertSaveSuccess() method * Move compareFiles method to TestUtil class * Minor changes in StorageFile class * remove trailing whitespaces and unused imports * remove unused import * Change to return directly as addressbook * Rework and rename compareFile() to assertTextFilesEqual() * Use of temporary folder and minor style issues * Remove trailing whitespaces * minor style changes * Extract temp.txt to constant string * rework assertSaveSuccess() method * change of javadoc * Minor changes * Javadoc language * Javadoc change * Javadoc change
Configuration menu - View commit details
-
Copy full SHA for 24335db - Browse repository at this point
Copy the full SHA 24335dbView commit details
Commits on Jan 2, 2017
-
Configuration menu - View commit details
-
Copy full SHA for 753fcc1 - Browse repository at this point
Copy the full SHA 753fcc1View commit details
Commits on Jan 3, 2017
-
[nus-cs2103-AY1617S2#110] Add unit tests for FindCommand class (nus-c…
…s2103-AY1617S2#120) * Add testutil classes to facilitate testing * Add TestMain class to facilitate testing of commands * Add equals() methond in AddressBook, UniquePersonList and UniqueTagList * Add FindCommandTest and CommandTest * Fix code style * Add indentation for equals() method * Reimplement FindCommandTest without use of TestMain * Remove duplicate equals() method in UniquePersonList * Remove TestPerson class * Refactor FindCommandTest * Refactor FindCommandTest * Refactor FindCommandTest * Remove empty line at top of assertCommandBehavior * Refactor TypicalPersons.java and shift instantiating a FindCommand in FindCommandTest to asserCommandBehavior method * Rename assertCommandBehavior to assertFindCommandBehavior * Remove PersonBuilder and make TypicalPersons fields non-static * Refactor FindCommandTest by inlining test methods * Remove unused imports * Add new test cases * Remove trailing empty lines * Fix coding style * Remove unused imports * Remove trailing whitespaces
Configuration menu - View commit details
-
Copy full SHA for a909e09 - Browse repository at this point
Copy the full SHA a909e09View commit details -
[nus-cs2103-AY1617S2#130] Change file extension requirement from .txt…
… to .xml (nus-cs2103-AY1617S2#132) * change file ext requirement from txt to xml * test script change
Configuration menu - View commit details
-
Copy full SHA for 2fdb124 - Browse repository at this point
Copy the full SHA 2fdb124View commit details
Commits on Jan 8, 2017
-
[nus-cs2103-AY1617S2#117] Names with unicode characters are treated a…
…s invalid (nus-cs2103-AY1617S2#138) This reverts commit c61e65b, reversing changes made to 4070eff.
Configuration menu - View commit details
-
Copy full SHA for 70f60ba - Browse repository at this point
Copy the full SHA 70f60baView commit details
Commits on Feb 2, 2017
-
Configuration menu - View commit details
-
Copy full SHA for b046a9d - Browse repository at this point
Copy the full SHA b046a9dView commit details