Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T4A2][T15-A1] Neo Wei Jie, Esmond #1701

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Commits on Aug 30, 2016

  1. Update regex for better Name matching

    Fix comment in Address.java (initially it was email for address)
    update tests to validate: new name regex
    okkhoy committed Aug 30, 2016
    Configuration menu
    Copy the full SHA
    db3978d View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    730ea58 View commit details
    Browse the repository at this point in the history

Commits on Oct 5, 2016

  1. Configuration menu
    Copy the full SHA
    c3ac0d5 View commit details
    Browse the repository at this point in the history
  2. add more tests to check for dash, dot, qote and unicode characters in…

    … the
    
    name
    update expected.txt to reflect the new changes
    okkhoy committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    cec9204 View commit details
    Browse the repository at this point in the history
  3. fixed regex to "^[\\p{L}0-9 .'-]+$", the prev one did not have numbers

    hence any name with numeric characer would be rejected.
    okkhoy committed Oct 5, 2016
    Configuration menu
    Copy the full SHA
    adef5c6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    bf7f6bc View commit details
    Browse the repository at this point in the history

Commits on Oct 6, 2016

  1. Configuration menu
    Copy the full SHA
    8928fef View commit details
    Browse the repository at this point in the history

Commits on Oct 20, 2016

  1. Configuration menu
    Copy the full SHA
    02b59fc View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2016

  1. Configuration menu
    Copy the full SHA
    c61e65b View commit details
    Browse the repository at this point in the history

Commits on Nov 27, 2016

  1. Add codacy badge

    damithc authored Nov 27, 2016
    Configuration menu
    Copy the full SHA
    2283852 View commit details
    Browse the repository at this point in the history

Commits on Dec 7, 2016

  1. Configuration menu
    Copy the full SHA
    43c506d View commit details
    Browse the repository at this point in the history

Commits on Dec 8, 2016

  1. Configuration menu
    Copy the full SHA
    7518552 View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2016

  1. Configuration menu
    Copy the full SHA
    f196968 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2016

  1. [nus-cs2103-AY1617S2#108] Add unit tests for AddCommand class (nus-cs…

    …2103-AY1617S2#118)
    
    * [nus-cs2103-AY1617S2#108] add unit tests for add command
    
    * renamed methods for consistency
    
    * capitalize todo
    Neurrone authored and pyokagan committed Dec 11, 2016
    Configuration menu
    Copy the full SHA
    88133a6 View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2016

  1. [nus-cs2103-AY1617S2#124] Fix code style violation (nus-cs2103-AY1617…

    …S2#125)
    
    * Fix code style violation reported by checkstyle
    
    * Fix checkstyle issues in AddCommandTest
    yamgent authored and pyokagan committed Dec 13, 2016
    Configuration menu
    Copy the full SHA
    7d1de69 View commit details
    Browse the repository at this point in the history

Commits on Dec 22, 2016

  1. [nus-cs2103-AY1617S2#107] Add unit tests for Utils class (nus-cs2103-…

    …AY1617S2#127)
    
    * Add unit test for Utils class
    
    * Reduce the number of test cases in isAnyNull method
    
    * Reduce number of test cases in elementsAreUnique method
    
    * Change assertAreUnique and assertNotUnique methods to private and remove
    extra spaces
    
    * Remove @before
    
    * Remove try catch clause
    
    * Inline buildTag method
    
    * Change test tag to local variable
    
    * Remove unused import
    
    * Extract createList() method and remove arraylist
    
    * Remove constant
    
    * Rearrange test cases to avoid confusion
    
    * Rename variable
    
    * add test cases to prevent false negative
    
    * Inline createList method
    
    * Rearrange test cases and remove whitespaces
    
    * Add newline at eof
    
    * Added spaces for type casting
    
    * Update comment for UtilsTest
    zzzzwen authored and pyokagan committed Dec 22, 2016
    Configuration menu
    Copy the full SHA
    1a15e66 View commit details
    Browse the repository at this point in the history

Commits on Dec 28, 2016

  1. [nus-cs2103-AY1617S2#104] Add unit tests for StorageFile class (nus-c…

    …s2103-AY1617S2#128)
    
    * Add unit test for StorageFile class
    
    * Change indentation and add comments
    
    * Make invalid data file more obvious
    
    * Create Utility method getStorage
    
    * Change contains method to equals method
    
    * Style change in StorageFileTest
    
    * Style changes in StorageFileTest
    
    * Inline getStorage method
    
    * Remove unused import
    
    * Revert "Inline getStorage method"
    
    This reverts commit f431d12.
    
    * Re-adjust getStorage() method
    
    * Change assertTrue() to assertEquals
    
    * Move test files to correct folder
    
    * Add test persons and extract to a method
    
    * Rework assertSaveSuccess() method
    
    * Move compareFiles method to TestUtil class
    
    * Minor changes in StorageFile class
    
    * remove trailing whitespaces and unused imports
    
    * remove unused import
    
    * Change to return directly as addressbook
    
    * Rework and rename compareFile() to assertTextFilesEqual()
    
    * Use of temporary folder and minor style issues
    
    * Remove trailing whitespaces
    
    * minor style changes
    
    * Extract temp.txt to constant string
    
    * rework assertSaveSuccess() method
    
    * change of javadoc
    
    * Minor changes
    
    * Javadoc language
    
    * Javadoc change
    
    * Javadoc change
    zzzzwen authored and pyokagan committed Dec 28, 2016
    Configuration menu
    Copy the full SHA
    24335db View commit details
    Browse the repository at this point in the history

Commits on Jan 2, 2017

  1. Configuration menu
    Copy the full SHA
    753fcc1 View commit details
    Browse the repository at this point in the history

Commits on Jan 3, 2017

  1. [nus-cs2103-AY1617S2#110] Add unit tests for FindCommand class (nus-c…

    …s2103-AY1617S2#120)
    
    * Add testutil classes to facilitate testing
    
    * Add TestMain class to facilitate testing of commands
    
    * Add equals() methond in AddressBook, UniquePersonList and UniqueTagList
    
    * Add FindCommandTest and CommandTest
    
    * Fix code style
    
    * Add indentation for equals() method
    
    * Reimplement FindCommandTest without use of TestMain
    
    * Remove duplicate equals() method in UniquePersonList
    
    * Remove TestPerson class
    
    * Refactor FindCommandTest
    
    * Refactor FindCommandTest
    
    * Refactor FindCommandTest
    
    * Remove empty line at top of assertCommandBehavior
    
    * Refactor TypicalPersons.java and shift instantiating a FindCommand in FindCommandTest to asserCommandBehavior method
    
    * Rename assertCommandBehavior to assertFindCommandBehavior
    
    * Remove PersonBuilder and make TypicalPersons fields non-static
    
    * Refactor FindCommandTest by inlining test methods
    
    * Remove unused imports
    
    * Add new test cases
    
    * Remove trailing empty lines
    
    * Fix coding style
    
    * Remove unused imports
    
    * Remove trailing whitespaces
    awhdes authored and pyokagan committed Jan 3, 2017
    Configuration menu
    Copy the full SHA
    a909e09 View commit details
    Browse the repository at this point in the history
  2. [nus-cs2103-AY1617S2#130] Change file extension requirement from .txt…

    … to .xml (nus-cs2103-AY1617S2#132)
    
    * change file ext requirement from txt to xml
    
    * test script change
    zzzzwen authored and pyokagan committed Jan 3, 2017
    Configuration menu
    Copy the full SHA
    2fdb124 View commit details
    Browse the repository at this point in the history

Commits on Jan 8, 2017

  1. [nus-cs2103-AY1617S2#117] Names with unicode characters are treated a…

    …s invalid (nus-cs2103-AY1617S2#138)
    
    This reverts commit c61e65b, reversing
    changes made to 4070eff.
    Neurrone authored and damithc committed Jan 8, 2017
    Configuration menu
    Copy the full SHA
    70f60ba View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2017

  1. T3A2:

    Encapsulated feedbackToUser
    zeticous committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    6dc39b2 View commit details
    Browse the repository at this point in the history
  2. T3A3: Create Class

    Buggy implementation. To be fixed.
    zeticous committed Jan 27, 2017
    Configuration menu
    Copy the full SHA
    91d0dac View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2017

  1. Fixes for StorageOperationException and T3A2

    StorageOperationException:
    - Delete addressbook.xml before testing.
    
    Buggy implementation of T3A2:
    - Change feedbackToUser to getFeedbackToUser in Add, Delete and Find Command.
    zeticous committed Jan 30, 2017
    Configuration menu
    Copy the full SHA
    7274ea8 View commit details
    Browse the repository at this point in the history
  2. [T3A5] Added PrefixFormatter

    PrefixFormatter:
    Implemented SRP to formatting the messages for printing.
    zeticous committed Jan 30, 2017
    Configuration menu
    Copy the full SHA
    0fdfc4f View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2017

  1. Configuration menu
    Copy the full SHA
    4a26550 View commit details
    Browse the repository at this point in the history