Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[T4A3][T15-A1] Neo Wei Jie, Esmond #1702

Open
wants to merge 26 commits into
base: master
Choose a base branch
from

Conversation

zeticous
Copy link

@zeticous zeticous commented Feb 8, 2017

Ready for review.

okkhoy and others added 26 commits August 30, 2016 17:11
Fix comment in Address.java (initially it was email for address)
update tests to validate: new name regex
… the

name
update expected.txt to reflect the new changes
hence any name with numeric characer would be rejected.
…2103-AY1617S2#118)

* [nus-cs2103-AY1617S2#108] add unit tests for add command

* renamed methods for consistency

* capitalize todo
…S2#125)

* Fix code style violation reported by checkstyle

* Fix checkstyle issues in AddCommandTest
…AY1617S2#127)

* Add unit test for Utils class

* Reduce the number of test cases in isAnyNull method

* Reduce number of test cases in elementsAreUnique method

* Change assertAreUnique and assertNotUnique methods to private and remove
extra spaces

* Remove @before

* Remove try catch clause

* Inline buildTag method

* Change test tag to local variable

* Remove unused import

* Extract createList() method and remove arraylist

* Remove constant

* Rearrange test cases to avoid confusion

* Rename variable

* add test cases to prevent false negative

* Inline createList method

* Rearrange test cases and remove whitespaces

* Add newline at eof

* Added spaces for type casting

* Update comment for UtilsTest
…s2103-AY1617S2#128)

* Add unit test for StorageFile class

* Change indentation and add comments

* Make invalid data file more obvious

* Create Utility method getStorage

* Change contains method to equals method

* Style change in StorageFileTest

* Style changes in StorageFileTest

* Inline getStorage method

* Remove unused import

* Revert "Inline getStorage method"

This reverts commit f431d12.

* Re-adjust getStorage() method

* Change assertTrue() to assertEquals

* Move test files to correct folder

* Add test persons and extract to a method

* Rework assertSaveSuccess() method

* Move compareFiles method to TestUtil class

* Minor changes in StorageFile class

* remove trailing whitespaces and unused imports

* remove unused import

* Change to return directly as addressbook

* Rework and rename compareFile() to assertTextFilesEqual()

* Use of temporary folder and minor style issues

* Remove trailing whitespaces

* minor style changes

* Extract temp.txt to constant string

* rework assertSaveSuccess() method

* change of javadoc

* Minor changes

* Javadoc language

* Javadoc change

* Javadoc change
…s2103-AY1617S2#120)

* Add testutil classes to facilitate testing

* Add TestMain class to facilitate testing of commands

* Add equals() methond in AddressBook, UniquePersonList and UniqueTagList

* Add FindCommandTest and CommandTest

* Fix code style

* Add indentation for equals() method

* Reimplement FindCommandTest without use of TestMain

* Remove duplicate equals() method in UniquePersonList

* Remove TestPerson class

* Refactor FindCommandTest

* Refactor FindCommandTest

* Refactor FindCommandTest

* Remove empty line at top of assertCommandBehavior

* Refactor TypicalPersons.java and shift instantiating a FindCommand in FindCommandTest to asserCommandBehavior method

* Rename assertCommandBehavior to assertFindCommandBehavior

* Remove PersonBuilder and make TypicalPersons fields non-static

* Refactor FindCommandTest by inlining test methods

* Remove unused imports

* Add new test cases

* Remove trailing empty lines

* Fix coding style

* Remove unused imports

* Remove trailing whitespaces
… to .xml (nus-cs2103-AY1617S2#132)

* change file ext requirement from txt to xml

* test script change
Encapsulated feedbackToUser
Buggy implementation. To be fixed.
StorageOperationException:
- Delete addressbook.xml before testing.

Buggy implementation of T3A2:
- Change feedbackToUser to getFeedbackToUser in Add, Delete and Find Command.
PrefixFormatter:
Implemented SRP to formatting the messages for printing.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants