[euchangxian] iP #520
Open
[euchangxian] iP #520
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reduces repeated code.
This is done by adding an overloaded echo() method to maintain the functionality of existing code.
For improved readablity
Update startParse() to first split by spaces to handle commands with multiple words, like mark x or unmark x, where x is the index of the command.
This is to prevent Duke class from getting too bloated.
This is to prevent bloating of Duke class
LicongHuang
reviewed
Sep 5, 2023
| * | ||
| * @return {@code true} if the file was corrupted, otherwise {@code false}. | ||
| */ | ||
| public boolean wasFileCorrupted() { |
There was a problem hiding this comment.
Method name should start with a verb, i.e. checkFileCorrupted()
| return Optional.of(task); | ||
| } | ||
|
|
||
| public List<Task> searchTasks(String keyword) { |
| @@ -0,0 +1,9 @@ | |||
| todo master rizz | |||
This is in preparation to integrate JavaFX with Duke, preventing the Duke class from becoming too bloated.
Refactor existing classes, mainly changing the return type of UiService to return a String which is displayed in the GUI window.
Add a GUI to Duke.
PearlynnT
reviewed
Sep 6, 2023
| throw new InvalidCommandInputException("Provide a keyword for find command! :<"); | ||
| } | ||
| return new FindTaskCommand(dukeBot, uiService, args.get(0)); | ||
| case "todo": |
There was a problem hiding this comment.
Suggested change
| case "todo": | |
| case "todo": | |
| // Fallthrough |
The explicit // Fallthrough comment should be included whenever there is a case statement without a break statement.
| } | ||
| return new FindTaskCommand(dukeBot, uiService, args.get(0)); | ||
| case "todo": | ||
| case "deadline": |
There was a problem hiding this comment.
Suggested change
| case "deadline": | |
| case "deadline": | |
| // Fallthrough |
The explicit // Fallthrough comment should be included whenever there is a case statement without a break statement.
| return Optional.of(task); | ||
| } | ||
|
|
||
| public List<Task> searchTasks(String keyword) { |
|
|
||
| try (FileInputStream fis = new FileInputStream(file); | ||
| ObjectInputStream ois = new ObjectInputStream(fis)) { | ||
| @SuppressWarnings("unchecked") |
TaskFactory is responsible for the creation of new Tasks, and in no cases does it return a null task. Since there should only be one way of adding a task to TaskList, by calling TaskList::add, there should be no null tasks added to the TaskList. Neither should there by any null task retrieved by any exposed methods.
This is to better reflect immutability.
Add assert statements to TaskList
Branch-A-Streams
Add java_ci.yml file to ensure code quality
Improve Code Quality
Duke can now parse dates like "monday", "tuesday",..., etc and understands it as the next Monday, Tuesday etc.
Add more special date inputs
If the start date supplied is after the end date, an exception is thrown.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚀 Changoose 🚀
🎉 This is the latest release of Changoose v0.1! 🎉
🤩 What's New? 🤩
(almost)anything you tell it!🦾 Performance Enhancements 🦾
deadline feed goose \by todayand Changoose will understand you!TODO
Here is the link to the code for Changoose!
Changoose