[vivienherq] iP #529

vivienherq · 2023-09-03T08:50:46Z

Dude

Dude frees your mind of having to remember things you need to do. It's:

text-based
easy to learn
FAST SUPER FAST to use

All you need to do is:

download it from here.
double-click it.
add your tasks.
let it manage your tasks for you 😉

And it is FREE!

Features:

Managing tasks
Managing deadlines
Managing events
Reminders (coming soon)

If you are a Java programmer, you can use it to practice Java too. Here's the main method:

public class Main {
    public static void main(String[] args) {
        Application.launch(MainApp.class, args);
    }
}

garylow2001

LGTM. Overall just some nits about coding standards!

garylow2001 · 2023-09-05T12:13:51Z

src/main/java/Event.java

+        this.from = from;
+        this.to = to;
+    }
+    public String getType() {


Perhaps you can add a @Override above your getType() method to specify that you wish to override this method from Task

garylow2001 · 2023-09-05T12:16:45Z

src/main/java/Dude.java

+
+//    static Task[] taskList = new Task[100];
+    static ArrayList<Task> taskList = new ArrayList<Task>();
+    static int nTasks = 0;


Instead of having an nTasks to keep track of the number of tasks in taskList why not use taskList.size()?

garylow2001 · 2023-09-05T12:19:33Z

src/main/java/Dude.java

+    public static void list() {
+        for (int i = 0; i < nTasks; i++) {
+            Task task = taskList.get(i);
+//            Task task = taskList[i];


You are using comments to temporarily remove code, however comments should be used to describe the code to the reader. They should also be indented to the relative position to your code i.e. the // needs to be on the same line as Task on line 47

garylow2001 · 2023-09-05T12:22:00Z

src/main/java/Dude.java

+
+    public static void mark(int n) {
+//        taskList[n-1].setDone(true);
+        taskList.get(n-1).setDone(true);


For clarity, perhaps you can split this line up into

selectedTask = taskList.get(n-1); selectedTask.setDone(true);

garylow2001 · 2023-09-05T12:22:38Z

src/main/java/Dude.java

+            String input = scanner.nextLine();
+            String[] words = input.split(" ");
+
+            if (words[0].equals("list")) {


Perhaps you can use switch statements for the control flow instead of if-else statements

samuelim01

LGTM, just a few nits about coding standards. Overall, good job 😄

samuelim01 · 2023-09-07T12:38:50Z

src/main/java/Dude.java

@@ -0,0 +1,213 @@
+import java.io.*;


Imported classes should be listed explicitly 😁

Suggested change

import java.io.*;

import java.io.BufferedReader;

import java.io.File;

import java.io.FileNotFoundException;

import java.io.FileReader;

import java.io.FileWriter;

import java.io.IOException;

samuelim01 · 2023-09-07T12:40:18Z

src/main/java/Task.java

@@ -0,0 +1,35 @@
+public class Task {
+    private String description;
+    private boolean done;


booleans variables should be named to sound like booleans

Suggested change

private boolean done;

private boolean isDone;

samuelim01 · 2023-09-07T12:44:09Z

src/main/java/Dude.java

+    }
+
+    public static void unmark(int n) throws IOException {
+        taskList.get(n-1).setDone(false);


Operators should be surrounded by a space character.

Suggested change

taskList.get(n-1).setDone(false);

taskList.get(n - 1).setDone(false);

samuelim01 · 2023-09-07T12:50:30Z

src/main/java/Deadline.java

+import java.util.Locale;
+
+public class Deadline extends Task {
+    LocalDateTime by;


Variables should be non-public.

Suggested change

LocalDateTime by;

private LocalDateTime by;

samuelim01 · 2023-09-07T12:55:25Z

src/main/java/Dude.java

+    static ArrayList<Task> taskList = new ArrayList<Task>();
+    static int nTasks = 0;
+
+    private static final String FILE_PATH = "./data/dude.txt";


This constant doesn't seem to be used. Did you forget to replace your instances of "./data/dude.txt" with FILE_PATH?

samuelim01 · 2023-09-07T12:57:29Z

data/dude.txt

This file can be excluded from commits!

Add Gradle support

Add JUnit tests

andrefoo

LGTM, minor fixes only.

andrefoo · 2023-09-13T07:36:23Z

src/main/java/dude/Ui.java

+
+import java.util.Scanner;
+public class Ui {
+    Scanner sc;


Logical units within a block should be separated by one blank line.
Consider making the variable 'sc' private as well!

Set up CI To run workflow (as per gradle.ymp file) every time certain project events are triggered.

Set up CI

Add classes and methods to support Notes in Dude

Current structure is not very organised after adding new classes. New packages are added and classes are moved into packages. * dude.ui package added * dude.note package added

Null values are returned for Task and Note. Null values in loaded data can lead to unexpected behaviour and errors in the application.

Find command is case-sensitive. A case-insensitive find is more user-friendly because users cannot be expected to remember the exact case of the keywords. * Update search algorithm to use case-insensitive matching

Branch a better gui

Branch A-MoreErrorHandling

Branch A-Personality

damithc and others added 13 commits August 9, 2023 02:16

Add Gradle support

28ad2b8

Bump gradle and lib version

ed6d4d2

rename

4b12bd6

greet & exit

a6f13d3

echo

6ae3cc1

store & list

cfc7c19

task class

ae180ce

mark & unmark

07d666a

lvl4 todo, event & deadline classes

4cec3c5

lvl4 todo

a056e50

lvl4 create todos, events, deadlines

acbfead

lvl 5 handle errors

0dadc72

lvl 6 delete

91b96cf

garylow2001 reviewed Sep 5, 2023

View reviewed changes

vivienherq added 3 commits September 6, 2023 20:07

add text ui testing

2445b29

add save tasks and load task

8f55d5e

implement datetime recognition for deadline

4fc7fc4

samuelim01 reviewed Sep 7, 2023

View reviewed changes

vivienherq and others added 10 commits September 12, 2023 01:57

Refactor code into Ui, Storage, Parser, TaskList, Command classes

725c47e

Revert latest commit to push to A-MoreOOP Branch

34281a2

Refactor code into Ui, Storage, Parser, TaskList, Command classes

6bcc6ec

Organise classes into packages

85e358c

Merge branch 'A-Packages'

8144a1c

Merge pull request #1 from vivienherq/add-gradle-support

89204e3

Add Gradle support

Add Gradle support

23714e1

Add JUnit tests

88e778a

Merge pull request #2 from vivienherq/A-JUnit

9b188fa

Add JUnit tests

Modify build.gradle for JAR creation

1fef7f7

andrefoo reviewed Sep 13, 2023

View reviewed changes

Implement find feature to search for tasks

0314cf6

vivienherq and others added 30 commits September 14, 2023 19:50

Set up CI

cc740a9

Set up CI To run workflow (as per gradle.ymp file) every time certain project events are triggered.

Merge pull request #9 from vivienherq/branch-A-CI

2a9f2ab

Set up CI

Add Note and NoteList classes

5f3101e

Add and modify methods to support Notes

bd2e27d

Fix Checkstyle violations

1130fc3

Merge pull request #10 from vivienherq/branch-D-Notes

35e7c49

Add classes and methods to support Notes in Dude

Reorganise project structure and add packages

19c71fe

Current structure is not very organised after adding new classes. New packages are added and classes are moved into packages. * dude.ui package added * dude.note package added

Fix Checkstyle violations

ffb7e1f

Storage: prevent null values from being returned

44cfd21

Null values are returned for Task and Note. Null values in loaded data can lead to unexpected behaviour and errors in the application.

Find command: make matching case-insensitive

c963ac1

Find command is case-sensitive. A case-insensitive find is more user-friendly because users cannot be expected to remember the exact case of the keywords. * Update search algorithm to use case-insensitive matching

Configure dimension and layout of GUI

af043e0

Improve GUI

d2a8732

Merge pull request #12 from vivienherq/branch-A-BetterGui

999bd2d

Branch a better gui

Add delete note command

1c87ec3

Add additional checks for error handling

2a15d2d

Add exceptions to Parser class

94c8ed9

Add exceptions to Storage class

fa95713

Improve error checking and exception handling for date and time

c40cdf4

Merge pull request #13 from vivienherq/branch-A-MoreErrorHandling

e3b47f8

Branch A-MoreErrorHandling

Add delay before exiting and closing GUI

a527597

Add personality for Dude

3a58feb

Merge pull request #14 from vivienherq/branch-A-Personality

7197092

Branch A-Personality

Improve exception handling for parser

8abaff7

Upload image of UI

14375d2

Improve code quality

1c14b2f

Update README.md

fbe3510

Find command: support searching notes

4044a2c

Update README.md

224d2a7

Refactor classes into packages

8ec8d9e

Configure build.gradle to create fat JAR file

ddb13e1

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[vivienherq] iP #529

[vivienherq] iP #529

vivienherq commented Sep 3, 2023 •

edited

Loading

garylow2001 left a comment

garylow2001 Sep 5, 2023

garylow2001 Sep 5, 2023

garylow2001 Sep 5, 2023

garylow2001 Sep 5, 2023

garylow2001 Sep 5, 2023

samuelim01 left a comment

samuelim01 Sep 7, 2023

samuelim01 Sep 7, 2023

samuelim01 Sep 7, 2023

samuelim01 Sep 7, 2023

samuelim01 Sep 7, 2023

samuelim01 Sep 7, 2023

andrefoo left a comment

andrefoo Sep 13, 2023

-import java.io.*;
+import java.io.BufferedReader;
+import java.io.File;
+import java.io.FileNotFoundException;
+import java.io.FileReader;
+import java.io.FileWriter;
+import java.io.IOException;

	taskList.get(n-1).setDone(false);
	taskList.get(n - 1).setDone(false);

[vivienherq] iP #529

Are you sure you want to change the base?

[vivienherq] iP #529

Conversation

vivienherq commented Sep 3, 2023 • edited Loading

Dude

garylow2001 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

samuelim01 left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

andrefoo left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

vivienherq commented Sep 3, 2023 •

edited

Loading