[ChangruHenryQian] iP #544
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rionshocker
reviewed
Sep 7, 2023
src/main/java/Duke.java
Outdated
| private Storage storage; | ||
| private TaskList tasks; | ||
| private Ui ui = new Ui(); | ||
| private static final String filePath = "./data/duke.txt"; |
There was a problem hiding this comment.
Since it is a constant, may I suggest this change?
Suggested change
| private static final String filePath = "./data/duke.txt"; | |
| private static final String FILE_PATH = "./data/duke.txt"; |
billieboy7
reviewed
Sep 9, 2023
src/main/java/duke/Parser.java
Outdated
| } | ||
|
|
||
| public void parse() { | ||
| try{ |
There was a problem hiding this comment.
using switch statements may help reduce nesting. what do you think?
src/main/java/duke/Parser.java
Outdated
| this.taskList.addTask(newToDo); | ||
| } else if (command.startsWith("deadline")) { | ||
| LocalDate deadline = LocalDate.parse(command.split(" /by ", 2)[1]); | ||
| String name = command.split(" /by ", 2)[0].split(" ", 2)[1]; |
There was a problem hiding this comment.
Perhaps splitting them into multiple statements could improve the readability of the code. It can make it easier for you to debug your code too :)
| @@ -0,0 +1,83 @@ | |||
| package duke; | |||
|
|
|||
| import java.io.File; | |||
There was a problem hiding this comment.
I like how you have organised your imports according to their functionality. It's clear and easy to read. Great job!
| return "[" + this.getStatusIcon() + "] " + this.description; | ||
| } | ||
|
|
||
| public String toTxt() { |
There was a problem hiding this comment.
just a trivial issue but would spelling out the txt improve the readability of your code?
added 9 commits
September 9, 2023 19:58
After implementing GUI, the entry point was changed. Let's change mainClass into duke.Launcher.
The functional code is not capable of checking assumptions. Assumptions may not be true in some cases and checking is required. Let's add assert feature to document important assumptions.
Some parts of the code have bad code quality. Improvements on code quality increase readability. Let's improve code quality through methods such as refactoring.
Improve code quality
# Conflicts: # src/main/java/duke/Storage.java
Implement assertions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Jarvis Chat Bot
Jarvis frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features:
If you Java programmer, you can use it to practice Java too. Here's the
mainmethod: