-
Notifications
You must be signed in to change notification settings - Fork 519
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CS2103T-F12-1] NetConnect #172
Open
purivirakarin
wants to merge
642
commits into
nus-cs2103-AY2324S2:master
Choose a base branch
from
AY2324S2-CS2103T-F12-1:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[CS2103T-F12-1] NetConnect #172
purivirakarin
wants to merge
642
commits into
nus-cs2103-AY2324S2:master
from
AY2324S2-CS2103T-F12-1:master
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #172 +/- ##
============================================
- Coverage 75.26% 74.85% -0.41%
- Complexity 419 432 +13
============================================
Files 71 75 +4
Lines 1338 1380 +42
Branches 126 130 +4
============================================
+ Hits 1007 1033 +26
- Misses 301 310 +9
- Partials 30 37 +7 ☔ View full report in Codecov by Sentry. |
UI Changes: Add Destructive warnings to improve UX
Change Model#setPerson to enforce id not modified
Refactor code
Remove remark command
Refactor statestorage under storage
Add stack filters feature
Update Export CSV to export current view
Update the index.md for the NetConnect Website
User Guide: Updates for v1.3
AddCommand: Add checks for role specific fields
Update info and warning boxes to use markbind box
Dg improvements v1.4
Update index.md
Developer Guide: Update the Person Role Implementation
Edit ToC hyperlink and add line break
Add planned enhancements
Add page break to User Guide
Update UG formatting
User Guide: Updating the JobTitle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NetConnect help manage staff, supplier vendors and client information in the company (streamline their contact management tasks)