[Haris-Irfan] iP #618

Haris-Irfan · 2024-09-01T11:30:08Z

No description provided.

In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.

wenjebs · 2024-09-02T02:50:46Z

src/main/java/KieTwoForOne.java

+    public static boolean isCompleteInput(String[] input) throws KieTwoForOneException {
+        if (input.length <= 1 && !input[0].equalsIgnoreCase("list") && !input[0]. equalsIgnoreCase("bye")) {
+            throw new KieTwoForOneException();
+        }
+        return true;
+    }
+
+    public static boolean isCompleteEventInput(String[] input) throws KieTwoForOneException {
+        if (input.length != 3) {
+            throw new KieTwoForOneException();
+        }
+        return true;
+    }
+
+    public static boolean isCompleteDeadlineInput(String[] input) throws KieTwoForOneException {
+        if (input.length != 2) {
+            throw new KieTwoForOneException();
+        }


Perhaps could change to
isInputComplete, isEventInputComplete, and isDeadlineInputComplete
to sound more explicit

wenjebs · 2024-09-02T02:51:20Z

src/main/java/KieTwoForOne.java

+
+public class KieTwoForOne {
+
+    private static ArrayList<Task> tasks = new ArrayList<>(100);


The number 100 is a magic number.
Consider defining it as a constant with a meaningful name, such as MAX_TASKS?

wenjebs · 2024-09-02T02:51:40Z

src/main/java/KieTwoForOne.java

+            switch (Instructions.valueOf(instruction[0].toUpperCase())) {
+                case LIST:
+                    KieTwoForOne.listTasks();
+                    break;
+                case BYE:
+                    System.out.println("Bye. Hope to see you again soon!");
+                    System.out.println(separationLine);
+                    break;
+                case MARK:
+                    try {
+                        KieTwoForOne.markTask(Integer.valueOf(instruction[1]));
+                    } catch (IndexOutOfBoundsException e) {
+                        System.out.println("Task does not exist!");
+                        System.out.println(separationLine);
+                        break;
+                    }
+                    break;
+                case UNMARK:
+                    try {
+                        KieTwoForOne.unmarkTask(Integer.valueOf(instruction[1]));
+                    } catch (IndexOutOfBoundsException e) {
+                        System.out.println("Task does not exist!");
+                        System.out.println(separationLine);
+                        break;
+                    }
+                    break;
+                case TODO:
+                    KieTwoForOne.addTasks(new Todo(instruction[1]));
+                    break;
+                case EVENT:
+                    try  {
+                        isCompleteEventInput(taskDetails);
+                    } catch (KieTwoForOneException e){
+                        System.out.println("Please input a start and end time!");
+                        System.out.println(separationLine);
+                        break;
+                    }
+                    KieTwoForOne.addTasks(new Event(taskDetails[0], taskDetails[1], taskDetails[2]));
+                    break;
+                case DEADLINE:
+                    try {
+                        isCompleteDeadlineInput(taskDetails);
+                    } catch (KieTwoForOneException e) {
+                        System.out.println("Please input a deadline!");
+                        System.out.println(separationLine);
+                        break;
+                    }
+                    KieTwoForOne.addTasks(new Deadline(taskDetails[0], taskDetails[1]));
+                    break;
+                case DELETE:
+                    try {
+                        deleteTask(Integer.valueOf(instruction[1]));
+                    } catch (IndexOutOfBoundsException e) {
+                        System.out.println("Task does not exist!");
+                        System.out.println(separationLine);
+                        break;
+                    }
+                    break;
+                default:
+                    break;
+            }
+            if (instruction[0].equalsIgnoreCase("bye")) {
+                break;
+            }


Fix styling to align with styleguide?

Edwin1022 · 2024-09-04T17:27:12Z

src/main/java/Duke.java

+
+        while(true) {
+            String instruction = scanner.nextLine();
+            switch (instruction.toUpperCase()) {


Shouldn't there be no indentation for case clauses?

Edwin1022 · 2024-09-04T17:34:13Z

src/main/java/KieTwoForOne.java

+
+        while(true) {
+            String instruction = scanner.nextLine();
+            switch (instruction.toUpperCase()) {


Shouldn't there be no indentation for case clauses?

Edwin1022 · 2024-09-04T17:37:24Z

src/main/java/KieTwoForOne.java

    private static int count = 0;
    static String separationLine = "_________________________________________";
    static String chatBotName = "KieTwoForOne";

-    public static void addTasks(String task) {
-        tasks[count] = task;
+    public enum Instructions {


I like how you use enum to represent all the instructions.

Edwin1022 · 2024-09-04T17:38:22Z

src/main/java/KieTwoForOne.java

+            String input = scanner.nextLine().toUpperCase();
+            String[] instruction = input.split(" ", 2);
+
+            switch (Instructions.valueOf(instruction[0])) {


Shouldn't there be no indentation for case clauses?

Include the exception thrown in the default case of the switch statement in the parse method. Ensures that by default any invalid inputs will display an "Invalid input" in the chatbot. Include missing Java Documentation for some methods

Implement assertions Implement assertions to ensure certain assumptions in different methods are true.

Improve code quality Include the exception thrown in the default case of the switch statement in the parse method. Ensures that by default any invalid inputs will display an "Invalid input" in the chatbot. Include missing Java Documentation for some methods

Tagging functionality allows users to tag their tasks with certain keywords such as #work and #play to better categorise the tasks in their list Done by inputting tag (index) /(tag) in the chatbot

Fixed issue with tagging functionality where invalid inputs were not being handled properly. Fixed issue with GUI where data from the tasks.txt file was not being loaded into the chatbot. Fixed issue where adding a deadline did not include the time of the deadline of the task.

Creates the file path needed to store task data when the user first opens the chatbot.

Included a screenshot of the application with data population (listing of different tasks currently added within the task list) A brief introduction to the chatbot and an in-depth guide to the different features that users can use.

The tagging method only tagged the task temporarily. Needed it such that tag was a permanent addition to the task

Edited JavaDoc comments so that they are in line with coding standards.

Description is not accurate or appealing to users Include more syntax styling and emojis Include more information on features

User guide for downloading the application not provided in README Include header for a guide to download the chatbot

User guide for downloading the application not provided in README Include short description on where users can find the JAR file and how to start the chatbot

User guide for downloading the application not provided in README Include a fenced code block to guide users on how to open JAR file

User guide for downloading the application not provided in README Edit description to provide users more clarity on where they can find the release and how to run the JAR file

README not formatted clearly Remove "Its features are listed below" Following section is not features

README not formatted clearly Add text for users to know where the features can be found Helps users find the features section

README not visually appealling Add italics to make README more attractive to users Adds variance to the text

README not visually appealing Include bold words to make the README more attractive to users Adds variance to the text

README not formatted clearly Add header for introduction Helps users identify the introduction

damithc and others added 15 commits July 11, 2024 16:52

Add Gradle support

68c58c1

Bump gradle and lib version

03523ec

Implement basic skeleton of chatbot

2063dca

Implement switch statement and scanner in main

6b9dc47

Rename project from Duke to KieTwoForOne

b0d0248

Implement adding and listing of tasks functionality

ba04115

Implement Task class

ec3a264

Implement mark and unmark functionality

d2db81a

Implement event, todo, and deadline functionality

5a50742

Implement automated Text UI testing

4ddf73a

Implement exceptions

9d6ea60

Convert Task[] array to ArrayList<Task>

6c4874b

Implement deletion functionality

c5052c3

Update automated Text UI testing

fbe0696

wenjebs suggested changes Sep 2, 2024

View reviewed changes

Edwin1022 reviewed Sep 4, 2024

View reviewed changes

Haris-Irfan added 13 commits September 6, 2024 00:55

Implement saving functionality

9017cbf

Merge branch 'branch-level-7'

6000982

Implement date time reading and filtering functionality

25cbb40

Merge branch 'branch-level-8'

83284e2

Implement more OOP

210ce03

Merge branch 'A-MoreOOP'

be5e203

Implement packages

9c2fab2

Merge branch 'A-Packages'

8676b51

Merge branch 'A-Gradle'

f3e91ac

Implement main package kietwoforone to put all classes in

334e5ba

Modify build.gradle from duke to KieTwoForOne

4de9757

Implement JUnit testing

c95e66d

Merge branch 'A-JUnit'

61de17d

Haris-Irfan and others added 30 commits September 13, 2024 05:38

Update README.md

4589e51

Merge branch 'master' of https://github.com/Haris-Irfan/ip

ff73301

Implement chatbot closing functionality

aa8c95d

Implement assertions

9609f22

Improve code quality

4907902

Include the exception thrown in the default case of the switch statement in the parse method. Ensures that by default any invalid inputs will display an "Invalid input" in the chatbot. Include missing Java Documentation for some methods

Merge pull request #2 from Haris-Irfan/branch-A-Assertions

f71046a

Implement assertions Implement assertions to ensure certain assumptions in different methods are true.

Merge branch 'master' of https://github.com/Haris-Irfan/ip

298bc46

Merge branch 'master' into branch-A-CodeQuality

3657837

Merge branch 'master' of https://github.com/Haris-Irfan/ip

4c99dea

Implement tagging functionality

b326900

Tagging functionality allows users to tag their tasks with certain keywords such as #work and #play to better categorise the tasks in their list Done by inputting tag (index) /(tag) in the chatbot

Merge branch 'branch-C-Tagging'

27d469e

Added file path creation functionality in the Storage class.

3468419

Creates the file path needed to store task data when the user first opens the chatbot.

Update README.md

aa99a00

Included a screenshot of the application with data population (listing of different tasks currently added within the task list) A brief introduction to the chatbot and an in-depth guide to the different features that users can use.

Include information on bye command to exit the application

f729335

Update Ui.png

bf6ba66

Clean up syntax in README.md

a63ad8f

Fix tagging functionality

7b8e920

The tagging method only tagged the task temporarily. Needed it such that tag was a permanent addition to the task

Fixed JavaDoc Comments.

bc8a2d4

Edited JavaDoc comments so that they are in line with coding standards.

Update README.md

74446b5

Description is not accurate or appealing to users Include more syntax styling and emojis Include more information on features

Update README.md

fed83dd

User guide for downloading the application not provided in README Include header for a guide to download the chatbot

Update README.md

853d82c

User guide for downloading the application not provided in README Include short description on where users can find the JAR file and how to start the chatbot

Update README.md

d538e9c

User guide for downloading the application not provided in README Include a fenced code block to guide users on how to open JAR file

Update README.md

88b7389

User guide for downloading the application not provided in README Edit description to provide users more clarity on where they can find the release and how to run the JAR file

Update README.md

ca1515e

README not formatted clearly Remove "Its features are listed below" Following section is not features

Update README.md

675cb81

README not formatted clearly Add text for users to know where the features can be found Helps users find the features section

Update README.md

2fd90d8

README not visually appealling Add italics to make README more attractive to users Adds variance to the text

Update README.md

616d902

README not visually appealing Include bold words to make the README more attractive to users Adds variance to the text

Update README.md

fb37bce

README not formatted clearly Add header for introduction Helps users identify the introduction

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[Haris-Irfan] iP #618

[Haris-Irfan] iP #618

Haris-Irfan commented Sep 1, 2024

wenjebs Sep 2, 2024

wenjebs Sep 2, 2024

wenjebs Sep 2, 2024

Edwin1022 Sep 4, 2024

Edwin1022 Sep 4, 2024

Edwin1022 Sep 4, 2024

Edwin1022 Sep 4, 2024


		public class KieTwoForOne {

		private static ArrayList<Task> tasks = new ArrayList<>(100);

[Haris-Irfan] iP #618

Are you sure you want to change the base?

[Haris-Irfan] iP #618

Conversation

Haris-Irfan commented Sep 1, 2024

wenjebs Sep 2, 2024

Choose a reason for hiding this comment

wenjebs Sep 2, 2024

Choose a reason for hiding this comment

wenjebs Sep 2, 2024

Choose a reason for hiding this comment

Edwin1022 Sep 4, 2024

Choose a reason for hiding this comment

Edwin1022 Sep 4, 2024

Choose a reason for hiding this comment

Edwin1022 Sep 4, 2024

Choose a reason for hiding this comment

Edwin1022 Sep 4, 2024

Choose a reason for hiding this comment