-
Notifications
You must be signed in to change notification settings - Fork 590
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[hpcman] iP #623
base: master
Are you sure you want to change the base?
[hpcman] iP #623
Conversation
In build.gradle, the dependencies on distZip and/or distTar causes the shadowJar task to generate a second JAR file for which the mainClass.set("seedu.duke.Duke") does not take effect. Hence, this additional JAR file cannot be run. For this product, there is no need to generate a second JAR file to begin with. Let's remove this dependency from the build.gradle to prevent the shadowJar task from generating the extra JAR file.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall, LGTM! Just suggested that the files should be put inside a package.
src/main/java/PacMan.java
Outdated
import java.util.ArrayList; | ||
import java.util.Scanner; | ||
|
||
public class PacMan { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you named your chatbot PacMan! Putting a figure behind the chatbot gives it more character.
|
||
Hello! I'm PacMan. How can I help you? | ||
Got it. I've added this task: | ||
[T][ ] CS2103T iP |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you made the tasks relevant to the class we are taking.
src/main/java/Task.java
Outdated
@@ -0,0 +1,18 @@ | |||
public class Task { | |||
private final String taskName; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
src/main/java/Todo.java
Outdated
@@ -0,0 +1,10 @@ | |||
public class Todo extends Task { | |||
Todo(String task) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like how you split up each type of task into different files, making the code really clean!
src/main/java/Deadline.java
Outdated
@@ -0,0 +1,13 @@ | |||
public class Deadline extends Task { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should all of this be in a package?
This reverts commit 39d5276.
…iable name from to by in addDeadline method for readability
… TaskList.java, Todo.java, Ui.java to PacMan folder and bundle them to packages
The past GUI is bare bone and not visually appealing. The GUI needs to be better for visual appeal and easier to separate the command and response. Let's, * use CSS FXML to make the background and dialog box
Branch a code quality
PacManPro
PacManPro frees your mind of having to remember things you need to do. It's,
FASTSUPER FAST to useAll you need to do is,
And it is FREE!
Features:
If you are a Java programmer, you can use it to practice Java too. Here's the
main
method: