-
Notifications
You must be signed in to change notification settings - Fork 78
[Ee Hong Zhi] ip #78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[Ee Hong Zhi] ip #78
Changes from 5 commits
ec3e31b
4012226
ef6234a
1121f60
3a479df
9083cfb
f228cbf
a567a55
c456b01
93e46ab
8f460f2
03444b5
c2ffd79
ab9ab3a
3e0de87
fc6ac44
303db32
5c24364
c90b832
6e4e802
067fb41
a7f0eba
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,19 @@ | ||||||||||
public class Deadline extends Task{ | ||||||||||
private String deadline; | ||||||||||
public Deadline(String description, String deadline){ | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
Similar to most of your methods, do remember to leave a space between the closing parenthesis and the opening curly brace. |
||||||||||
super(description); | ||||||||||
this.deadline = deadline; | ||||||||||
} | ||||||||||
|
||||||||||
@Override | ||||||||||
public void show(){ | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||
System.out.print("[D]["); | ||||||||||
if(isDone){ | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. It is also suggested to add a space after |
||||||||||
System.out.print("X"); | ||||||||||
} | ||||||||||
else{ | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to our coding standards, it is recommended to write the else branch like this. |
||||||||||
System.out.print(" "); | ||||||||||
} | ||||||||||
System.out.println("] " + description + " (by: " + deadline + ")"); | ||||||||||
} | ||||||||||
} |
Original file line number | Diff line number | Diff line change | ||||||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -1,10 +1,129 @@ | ||||||||||||||||||
import java.util.Scanner; | ||||||||||||||||||
|
||||||||||||||||||
public class Duke { | ||||||||||||||||||
public static void main(String[] args) { | ||||||||||||||||||
String logo = " ____ _ \n" | ||||||||||||||||||
+ "| _ \\ _ _| | _____ \n" | ||||||||||||||||||
+ "| | | | | | | |/ / _ \\\n" | ||||||||||||||||||
+ "| |_| | |_| | < __/\n" | ||||||||||||||||||
+ "|____/ \\__,_|_|\\_\\___|\n"; | ||||||||||||||||||
System.out.println("Hello from\n" + logo); | ||||||||||||||||||
static private Task[] taskList = new Task[100]; | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Plural form should be used on names representing a collection of objects. |
||||||||||||||||||
static private int numTasks = 0; | ||||||||||||||||||
|
||||||||||||||||||
public static void printLine(){ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||||||||||
System.out.println("____________________________________________________________"); | ||||||||||||||||||
} | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
public static void main(String[] args){ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||||||||||
|
||||||||||||||||||
System.out.println("Hello! I'm TheChattyFatty"); | ||||||||||||||||||
|
||||||||||||||||||
Scanner scanner = new Scanner(System.in); | ||||||||||||||||||
|
||||||||||||||||||
while(true) { | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is suggested to add a space after |
||||||||||||||||||
printLine(); | ||||||||||||||||||
System.out.println("What can I do for you?"); | ||||||||||||||||||
String response = scanner.nextLine(); | ||||||||||||||||||
|
||||||||||||||||||
// For handling keyword responses with multiple words | ||||||||||||||||||
String[] words = response.split(" "); | ||||||||||||||||||
|
||||||||||||||||||
String keyword = words[0]; | ||||||||||||||||||
|
||||||||||||||||||
// Handle "bye" keyword | ||||||||||||||||||
if(response.equals("bye")) { | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is suggested to add a space after |
||||||||||||||||||
break; | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
// Handle "list" keyword | ||||||||||||||||||
else if(response.equals("list")) { | ||||||||||||||||||
for (int i = 0; i < numTasks; i++) { | ||||||||||||||||||
taskList[i].show(); | ||||||||||||||||||
} | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
else if(keyword.equals("mark")){ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to our coding standards, it is recommended to write the else branch like this. |
||||||||||||||||||
// Check exception: number of words is not 2 | ||||||||||||||||||
if(words.length != 2){ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is suggested to add a space after |
||||||||||||||||||
System.out.println("Please enter with correct format: mark [Integer]"); | ||||||||||||||||||
} | ||||||||||||||||||
// Check exception: second word cannot be converted to integer or integer out of bounds | ||||||||||||||||||
try{ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||||||||||
int markIndex = Integer.parseInt(words[1]); | ||||||||||||||||||
|
||||||||||||||||||
if(markIndex < 1 || markIndex > numTasks){ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||||||||||
System.out.println("Please enter a positive integer less than or equal to current number of tasks (" + numTasks + ")"); | ||||||||||||||||||
continue; | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
taskList[markIndex - 1].mark(); | ||||||||||||||||||
} | ||||||||||||||||||
catch(NumberFormatException e){ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to our coding standards, it is recommended to write a try-catch statement like this. |
||||||||||||||||||
System.out.println("Please enter with correct format: mark [Integer]"); | ||||||||||||||||||
} | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Try to avoid deep nesting. Instead of deep nesting, you could break down your statements into additional methods. |
||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
else if(keyword.equals("unmark")){ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to our coding standards, it is recommended to write the else branch like this. |
||||||||||||||||||
// Check exception: number of words is not 2 | ||||||||||||||||||
if(words.length != 2){ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||||||||||
System.out.println("Please enter with correct format: unmark [Integer]"); | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
// Check exception: second word cannot be converted to integer or integer out of bounds | ||||||||||||||||||
try{ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||||||||||
int markIndex = Integer.parseInt(words[1]); | ||||||||||||||||||
|
||||||||||||||||||
if(markIndex < 1 || markIndex > numTasks){ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It is suggested to add a space after |
||||||||||||||||||
System.out.println("Please enter a positive integer less than or equal to current number of tasks (" + numTasks + ")"); | ||||||||||||||||||
continue; | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
taskList[markIndex - 1].unmark(); | ||||||||||||||||||
} | ||||||||||||||||||
catch(NumberFormatException e){ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to our coding standards, it is recommended to write a try-catch statement like this. |
||||||||||||||||||
System.out.println("Please enter with correct format: unmark [Integer]"); | ||||||||||||||||||
} | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
else if(keyword.equals("todo")){ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to our coding standards, it is recommended to write the else branch like this. |
||||||||||||||||||
String description = response.substring(5); | ||||||||||||||||||
taskList[numTasks] = new ToDo(description); | ||||||||||||||||||
numTasks++; | ||||||||||||||||||
|
||||||||||||||||||
System.out.println("Created new ToDo:"); | ||||||||||||||||||
System.out.println(description); | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
else if(keyword.equals("deadline")){ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to our coding standards, it is recommended to write the else branch like this. |
||||||||||||||||||
String description = response.substring(9); | ||||||||||||||||||
System.out.println("Please enter the deadline:"); | ||||||||||||||||||
String deadline = scanner.nextLine(); | ||||||||||||||||||
|
||||||||||||||||||
taskList[numTasks] = new Deadline(description, deadline); | ||||||||||||||||||
numTasks++; | ||||||||||||||||||
|
||||||||||||||||||
System.out.println("Created new Deadline:"); | ||||||||||||||||||
System.out.println(description); | ||||||||||||||||||
System.out.println("Due: " + deadline); | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
else if(keyword.equals("event")) { | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to our coding standards, it is recommended to write the else branch like this. |
||||||||||||||||||
String description = response.substring(6); | ||||||||||||||||||
System.out.println("Please enter event start period:"); | ||||||||||||||||||
String start = scanner.nextLine(); | ||||||||||||||||||
System.out.println("Please enter event end period:"); | ||||||||||||||||||
String end = scanner.nextLine(); | ||||||||||||||||||
|
||||||||||||||||||
taskList[numTasks] = new Event(description, start, end); | ||||||||||||||||||
numTasks++; | ||||||||||||||||||
|
||||||||||||||||||
System.out.println("Created new Event:"); | ||||||||||||||||||
System.out.println(description); | ||||||||||||||||||
System.out.println("From: " + start); | ||||||||||||||||||
System.out.println("To: " + end); | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
else{ | ||||||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to our coding standards, it is recommended to write the else branch like this. |
||||||||||||||||||
System.out.println("Invalid keyword"); | ||||||||||||||||||
System.out.println("Valid keywords are: list, todo, deadline, event, mark, unmark, bye"); | ||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
} | ||||||||||||||||||
|
||||||||||||||||||
System.out.println("Bye. Hope to see you again soon!"); | ||||||||||||||||||
} | ||||||||||||||||||
} |
Original file line number | Diff line number | Diff line change | ||||||||||||
---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,22 @@ | ||||||||||||||
public class Event extends Task{ | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||||||
private String start; | ||||||||||||||
private String end; | ||||||||||||||
|
||||||||||||||
public Event(String description, String start, String end){ | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||||||
super(description); | ||||||||||||||
this.start = start; | ||||||||||||||
this.end = end; | ||||||||||||||
} | ||||||||||||||
|
||||||||||||||
@Override | ||||||||||||||
public void show(){ | ||||||||||||||
System.out.print("[D]["); | ||||||||||||||
if(isDone){ | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||||||
System.out.print("X"); | ||||||||||||||
} | ||||||||||||||
else{ | ||||||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to our coding standards, it is recommended to write the else branch like this. |
||||||||||||||
System.out.print(" "); | ||||||||||||||
} | ||||||||||||||
System.out.println("] " + description + " (" + start + " to " + end + ")"); | ||||||||||||||
} | ||||||||||||||
} |
Original file line number | Diff line number | Diff line change | ||||||
---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,32 @@ | ||||||||
public class Task{ | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||
protected String description; | ||||||||
protected boolean isDone; | ||||||||
|
||||||||
public Task(String description){ | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||
this.description = description; | ||||||||
isDone = false; | ||||||||
} | ||||||||
|
||||||||
public void show(){ | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||
System.out.print("[?]["); | ||||||||
if(isDone){ | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||
System.out.print("X"); | ||||||||
} | ||||||||
else{ | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to our coding standards, it is recommended to write the else branch like this. |
||||||||
System.out.print(" "); | ||||||||
} | ||||||||
System.out.println("] " + description); | ||||||||
} | ||||||||
|
||||||||
public void mark(){ | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||
isDone = true; | ||||||||
System.out.println("Marked as done:"); | ||||||||
System.out.println(description); | ||||||||
} | ||||||||
|
||||||||
public void unmark(){ | ||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||
isDone = false; | ||||||||
System.out.println("Marked as not done yet:"); | ||||||||
System.out.println(description); | ||||||||
} | ||||||||
} |
Original file line number | Diff line number | Diff line change | ||||||||
---|---|---|---|---|---|---|---|---|---|---|
@@ -0,0 +1,17 @@ | ||||||||||
public class ToDo extends Task{ | ||||||||||
public ToDo(String description){ | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||
super(description); | ||||||||||
} | ||||||||||
|
||||||||||
@Override | ||||||||||
public void show(){ | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||
System.out.print("[T]["); | ||||||||||
if(isDone){ | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Adding a space before the curly bracket is more consistent with our coding conventions. |
||||||||||
System.out.print("X"); | ||||||||||
} | ||||||||||
else{ | ||||||||||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more.
Suggested change
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. According to our coding standards, it is recommended to write the else branch like this. |
||||||||||
System.out.print(" "); | ||||||||||
} | ||||||||||
System.out.println("] " + description); | ||||||||||
} | ||||||||||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Adding a space before the curly bracket is more consistent with our coding conventions.