Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(scoop-completions): correct substring indices to properly trim .ps1 extension #1056

Merged
merged 5 commits into from
Feb 24, 2025

Conversation

ziboh
Copy link
Contributor

@ziboh ziboh commented Feb 24, 2025

here will be an additional dot following each subcommand.
image

@ziboh
Copy link
Contributor Author

ziboh commented Feb 24, 2025

ls ([$bucketsDir, $bucket, 'bucket', '*.json'] | path join ) 
...
$all | where not $it in $installed

The two lines of code above cannot run.

@fdncred
Copy link
Contributor

fdncred commented Feb 24, 2025

There's a not-in operator that may be better than where not $it in $installed. You can see all the operators with help operators

@ziboh
Copy link
Contributor Author

ziboh commented Feb 24, 2025

There's a not-in operator that may be better than where not $it in $installed. You can see all the operators with help operators

Thanks, I'm a newbie using nushell

@fdncred
Copy link
Contributor

fdncred commented Feb 24, 2025

Is everything working the way you want it to now?

@ziboh
Copy link
Contributor Author

ziboh commented Feb 24, 2025

I've checked all the functions in Scoop's completion script.

@fdncred fdncred merged commit 8b40551 into nushell:main Feb 24, 2025
1 check passed
@fdncred
Copy link
Contributor

fdncred commented Feb 24, 2025

Thanks

@ziboh ziboh deleted the fix_scoop branch February 25, 2025 12:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants