Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ssh-completions when there's no includes #1065

Merged
merged 1 commit into from
Mar 8, 2025

Conversation

danmichaelo
Copy link
Contributor

@danmichaelo danmichaelo commented Mar 8, 2025

The ssh-completion didn't work when I first tried to source it. Turned out that reduce failed when $includes was an empty list:

$includes | par-each {|p| $p | open --raw | process } | reduce {|it| merge deep $it --strategy=append }

The change proposed in this PR fixes the problem so the completion also works if there are no includes in the ssh config files. I'm a total nushell beginner though, so I'm not sure if it's the best or the most idiomatic way to solve the problem :)

@fdncred fdncred merged commit e732b79 into nushell:main Mar 8, 2025
1 check passed
@fdncred
Copy link
Contributor

fdncred commented Mar 8, 2025

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants