Skip to content

Commit

Permalink
address review comments in the docs
Browse files Browse the repository at this point in the history
  • Loading branch information
supershal committed Jan 26, 2024
1 parent 623f0d2 commit 6e97e3e
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/content/customization/generic/global-mirror.md
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ If your registry mirror requires a private or self-signed CA certificate,
create a Kubernetes Secret with the `ca.crt` key populated with the CA certificate in PEM format:

```shell
kubectl create secret generic my-mirror-ca-cert-secret \
kubectl create secret generic my-mirror-ca-cert \
--from-file=ca.crt=registry-ca.crt
```

Expand All @@ -35,7 +35,7 @@ spec:
url: https://my-mirror.io
credentials:
secretRef:
name: my-mirror-ca-cert-secret
name: my-mirror-ca-cert
```
Applying this configuration will result in following new files on the
Expand Down
2 changes: 1 addition & 1 deletion pkg/handlers/generic/mutation/mirrors/variables_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ func TestVariableValidation(t *testing.T) {
ExpectError: true,
},
capitest.VariableTestDef{
Name: "registry URL without http(s) format and path",
Name: "mirror URL without format",
Vals: v1alpha1.GenericClusterConfig{
GlobalImageRegistryMirror: &v1alpha1.GlobalImageRegistryMirror{
URL: "a.b.c.example.com/a/b/c",
Expand Down

0 comments on commit 6e97e3e

Please sign in to comment.