refactor: Adopt simpler proxy generator funcs #124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mhrabovcin
approved these changes
Aug 30, 2023
Small tweak that satisfies my desire for side-effect free functions and I have also updated tests to have slightly better checks.
jimmidyson
force-pushed
the
jimmi/refactor-proxy-patch
branch
from
ccfc71a
to
85a68e0
Compare
jimmidyson
pushed a commit
that referenced
this pull request
Sep 20, 2023
🤖 I have created a release *beep* *boop* --- ## 0.1.0 (2023-09-20) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Use ghcr.io rather than Docker Hub by @jimmidyson in #5 * feat: deploy Calico with ClusterResourceSet by @dkoshkin in #9 * feat: Add helm chart by @jimmidyson in #10 * feat: Add Flux addons provider by @jimmidyson in #22 * feat: Delete CNI HelmRelease along with cluster by @jimmidyson in #23 * feat: Add API boilerplate by @jimmidyson in #25 * feat: Add ClusterAddonSet and ClusterAddon API types by @jimmidyson in #26 * feat: Enable controller manager by @jimmidyson in #27 * feat: delete Services type LoadBalancer on BeforeClusterDelete by @dkoshkin in #29 * feat: Use interface to register handlers by @jimmidyson in #98 * feat: Reintroduce manifest parser by @jimmidyson in #101 * feat: Add version flag by @jimmidyson in #106 * feat: Deploy calico CNI via CRS by @jimmidyson in #107 * docs: Add starter docs site by @jimmidyson in #112 * feat: add httpproxy external patch by @mhrabovcin in #115 * feat: Add audit policy patch by @jimmidyson in #126 * feat: Add API server cert SANs patch by @jimmidyson in #129 * feat: calculate default no_proxy values based on cluster by @mhrabovcin in #128 * feat: Update variable getter to handle nested fields by @jimmidyson in #138 * feat: Support infra-specific httpproxy patches by @dlipovetsky in #141 * feat: Add ClusterConfig variable and patch handler by @jimmidyson in #142 * feat: new Kubernetes image registry patch by @dkoshkin in #149 * feat: CNI provider deployment via variables instead of labels by @jimmidyson in #152 * feat: add etcd registry and tag patch and vars by @dkoshkin in #153 * feat: adds nfd by @faiq in #164 ### Fixes 🔧 * fix: Fix panic when applying CNI CRS via hook by @jimmidyson in #13 * fix: Calico deployment to work with CAPD template by @dkoshkin in #16 * fix: Incorrect request/response parameters in CP initialized handler by @jimmidyson in #105 * fix: Add missing AfterControlPlaneUpgradeLifecycleHandler interface by @jimmidyson in #113 * fix: Update to latest audit policy by @jimmidyson in #145 * fix: Do not require leader election for CAPI hooks server by @jimmidyson in #150 * fix: typo in HTTP proxy docs by @dkoshkin in #155 * fix: incorrect audit policy handler name by @dkoshkin in #156 * refactor: how handlers are added to server by @dkoshkin in #154 * fix: Handle multiple meta mutators cleanly by @jimmidyson in #159 * fix: use repository more consistently by @dkoshkin in #161 ### Other Changes * build: copy example from upstream by @jimmidyson in #2 * build: Add make recipes for deploying local builds by @jimmidyson in #11 * build: golang 1.20 by @jimmidyson in #15 * build: Upgrade tools (#24 by @jimmidyson in #24 * ci: Trigger checks on adding to merge queue by @jimmidyson in #28 * build: Upgrade tools and distroless base image by @jimmidyson in #58 * ci: Remove k8s restrictions on dependabot by @jimmidyson in #61 * ci: Add k8s restrictions on dependabot for 0.27 by @jimmidyson in #65 * build(deps): bump github.com/fluxcd/source-controller/api to 1.0.0-rc.1 by @jimmidyson in #71 * refactor: Strip back to base for initial actual development by @jimmidyson in #72 * ci: Add linting for helm chart by @jimmidyson in #73 * build: Upgrade tools by @jimmidyson in #82 * build: Use devbox instead of asdf by @jimmidyson in #96 * test: Add service LB deleter test by @jimmidyson in #99 * build: Add license headers to generated files by @jimmidyson in #100 * build: Remove unused platform files now that devbox is used by @jimmidyson in #103 * build: Fix up kubebuilder PROJECT file by @jimmidyson in #102 * build: Fix up hugo mod tidy by @jimmidyson in #122 * refactor: Use go 1.21 and new slices.Contains func by @jimmidyson in #123 * refactor: Adopt simpler proxy generator funcs by @jimmidyson in #124 * refactor: Move matchers to own package and add tests by @jimmidyson in #125 * refactor: Extract server to own package for easier reuse by @jimmidyson in #127 * test: Extract common variable testing funcs by @jimmidyson in #131 * test: Introduce simpler patch test helpers by @jimmidyson in #133 * refactor: Use controller manager to start runtime hooks server by @jimmidyson in #134 * build: Upgrade everything and use nix flakes for go tools by @jimmidyson in #135 * refactor: Move all helpers to common module by @jimmidyson in #139 * docs: Add default extension config name in docs by @jimmidyson in #143 * build: remove unused .tools-versions file by @dkoshkin in #144 * ci: Dependabot for common module by @jimmidyson in #146 * refactor: Use controller manager options for pprof handler by @jimmidyson in #151 * build: add tooling to generate examples files by @dkoshkin in #148 * build: Bump clusterctl to v1.5.1 and go to 1.21.1 by @jimmidyson in #157 * ci: Explicitly specify bash as shell for GHA run steps by @jimmidyson in #158 * docs: add new Calico variables by @dkoshkin in #160 * build: Remove currently unused flux by @jimmidyson in #163 ## New Contributors * @jimmidyson made their first contribution in #2 * @dkoshkin made their first contribution in #9 * @dependabot made their first contribution in #20 * @mhrabovcin made their first contribution in #115 * @dlipovetsky made their first contribution in #141 * @faiq made their first contribution in #164 **Full Changelog**: https://github.com/d2iq-labs/capi-runtime-extensions/commits/v0.1.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small tweak that satisfies my desire for side-effect free functions
and I have also updated tests to have slightly better checks.