Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: introduce a Go module for /api #331

Merged
merged 6 commits into from
Feb 7, 2024
Merged

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Feb 5, 2024

The intent is to make it easier to import the API in other projects. Split the PR into a few commits to make it easier to review.

The changes are just moving files around, no actual code changes.

@dkoshkin dkoshkin force-pushed the dkoshkin/api-go.mod branch 3 times, most recently from 425b9f0 to 3f29b6b Compare February 5, 2024 22:57
@github-actions github-actions bot added feature and removed feature labels Feb 5, 2024
@dkoshkin dkoshkin force-pushed the dkoshkin/api-go.mod branch 2 times, most recently from a745bb1 to 9776508 Compare February 6, 2024 17:11
@github-actions github-actions bot added feature and removed feature labels Feb 6, 2024
The intent is to make it easier to import the API in other projects.
The goal is to remove dependency on the common/ package from /api
The goal is to remove dependency on the common/ package from /api
@dkoshkin dkoshkin force-pushed the dkoshkin/api-go.mod branch 2 times, most recently from 866aa09 to 040ae24 Compare February 6, 2024 17:52
@dkoshkin dkoshkin marked this pull request as ready for review February 6, 2024 17:54
@dkoshkin
Copy link
Contributor Author

dkoshkin commented Feb 6, 2024

For some reason the pre-commit job is failing to install the hook, even-though none of that change.
Anyone seen this before?

Fixed in 4503c5f, lmk if thats ok

The goal is to remove dependency on the common/ package from /api
Copy link
Contributor

@supershal supershal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested the changes locally.

Copy link
Member

@jimmidyson jimmidyson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great job!

@jimmidyson jimmidyson merged commit 07f5568 into main Feb 7, 2024
10 checks passed
@jimmidyson jimmidyson deleted the dkoshkin/api-go.mod branch February 7, 2024 10:27
@github-actions github-actions bot mentioned this pull request Feb 7, 2024
dkoshkin pushed a commit that referenced this pull request Feb 8, 2024
🤖 I have created a release *beep* *boop*
---


## 0.3.0 (2024-02-07)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: starts additional sec groups by @faiq in
#252
* feat: add control-plane load balancer scheme patch by @dkoshkin in
#228
* feat: Pull in CAAPH APIs by @jimmidyson in
#282
* feat: Use latest dynamic credential provider and v1 kubelet API by
@jimmidyson in
#293
* feat: Add ClusterResourceSet strategy for CNI installation by
@jimmidyson in
#288
* feat: Use CAAPH to deploy Calico on workload clusters by @jimmidyson
in #283
* feat: containerd configuration for mirror registry by @supershal in
#292
* feat: introduce a Go module for /api by @dkoshkin in
#331
### Fixes 🔧
* fix: Stable EBS CSI manifests by @jimmidyson in
#270
* fix: Ensure registry credentials are namespace local to Cluster by
@jimmidyson in
#332
### Other Changes
* build: Upgrade devbox tools by @jimmidyson in
#271
* ci: Update release please configuration for v4 action by @jimmidyson
in #274
* build: Add release conventional commut type for release PRs by
@jimmidyson in
#276
* docs: Add intro page to user docs by @jimmidyson in
#280
* build: Use ko for building OCI image by @jimmidyson in
#281
* build: Add files for clusterctl compatibility by @jimmidyson in
#284
* build: local development in macOS(and Linux) arm64/amd64 using local
colima instance by @supershal in
#285
* build: Lint for missed errors in tests too by @jimmidyson in
#287
* build: Remove unused upx makefile stuff by @jimmidyson in
#291
* docs: Fix indentation of AWS secret example by @jimmidyson in
#294
* build: Add k8s 1.28 KinD for testing by default by @jimmidyson in
#295
* build: Add devbox update scheduled job by @jimmidyson in
#310
* build(main): Latest devbox update (2024-01-22) by @github-actions in
#315
* ci: Group k8s mod updates for dependabot by @jimmidyson in
#316
* build(main): Latest devbox update (2024-01-24) by
@d2iq-labs-actions-pr-bot in
#320
* build(main): Latest devbox update (2024-02-05) by
@d2iq-labs-actions-pr-bot in
#326
* docs: fix cluster name in README by @dkoshkin in
#330
* ci: Consistent bash defaults in workflows by @jimmidyson in
#336
* ci: Tag api module on release by @jimmidyson in
#335

## New Contributors
* @d2iq-labs-actions-pr-bot made their first contribution in
#320

**Full Changelog**:
v0.2.0...v0.3.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants