Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add a Makefile target to update image #346

Merged
merged 1 commit into from
Feb 12, 2024

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Feb 9, 2024

Added a new Makefile target to just build and redeploy the webhook on an existing kind cluster.
This target is useful when testing bug fixes in downstream projects.

@jimmidyson
Copy link
Member

How about we just update run on kind target to skip clusterctl init if providers are already deployed?

@dkoshkin
Copy link
Contributor Author

dkoshkin commented Feb 9, 2024

How about we just update run on kind target to skip clusterctl init if providers are already deployed?

I was using this in DKP where its not using the Helm Chart directly to deploy it, so helm upgrade failed because of conflicting resources without the proper Helm labels.

make/dev.mk Show resolved Hide resolved
@jimmidyson jimmidyson merged commit 0511fb4 into main Feb 12, 2024
14 checks passed
@jimmidyson jimmidyson deleted the dkoshkin/make-dev-image branch February 12, 2024 10:00
@github-actions github-actions bot mentioned this pull request Feb 12, 2024
dkoshkin pushed a commit that referenced this pull request Feb 12, 2024
🤖 I have created a release *beep* *boop*
---


## 0.4.0 (2024-02-12)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Exciting New Features 🎉
* feat: Support multiple registry credentials if specified by
@jimmidyson in
#343
* feat: Add Cilium CNI addon support by @jimmidyson in
#333
### Fixes 🔧
* fix: downgrade Calico to v3.26.4 by @dkoshkin in
#348
* fix: AMI ID patch by @dkoshkin in
#345
* fix: use correct AWS EBS CSI images by @dkoshkin in
#344
### Other Changes
* build(main): Latest devbox update (2024-02-12) by
@d2iq-labs-actions-pr-bot in
#349
* build: Fix up lint config for moved external APIs by @jimmidyson in
#355
* test: add a Makefile target to update image by @dkoshkin in
#346


**Full Changelog**:
v0.3.5...v0.4.0

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants