Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: restart Containerd when setting mirror config #374

Merged
merged 1 commit into from
Feb 16, 2024

Conversation

dkoshkin
Copy link
Contributor

@dkoshkin dkoshkin commented Feb 16, 2024

Updates under this directory do not require restarting the containerd daemon.

Even-though a restart is not required on changes, it is still required initially after setting config_path in the Containerd config.


Tested locally with a CAPD cluster:

root@docker-quick-start-helm-addon-cilium-ng7q8-7xcrh:/# journalctl -u containerd | grep starting
Feb 16 01:42:07 docker-quick-start-helm-addon-cilium-ng7q8-7xcrh containerd[129]: time="2024-02-16T01:42:07.338020972Z" level=info msg="starting containerd" revision=1677a17964311325ed1c31e2c0a3589ce6d5c30d version=v1.7.1
Feb 16 01:42:17 docker-quick-start-helm-addon-cilium-ng7q8-7xcrh containerd[495]: time="2024-02-16T01:42:17.495879170Z" level=info msg="starting containerd" revision=1677a17964311325ed1c31e2c0a3589ce6d5c30d version=v1.7.1

Also tested in an AWS instance with a globalMirrorRegistry configuration and after restarting Containerd, the Kubelet was able to start Pods.

@dkoshkin dkoshkin self-assigned this Feb 16, 2024
@github-actions github-actions bot added the fix label Feb 16, 2024
@dkoshkin dkoshkin force-pushed the dkoshkin/fix-containerd-restart branch from 3f2b615 to 8ce1d5d Compare February 16, 2024 02:02
@github-actions github-actions bot added fix and removed fix labels Feb 16, 2024
@dkoshkin dkoshkin merged commit 65668eb into main Feb 16, 2024
15 checks passed
@dkoshkin dkoshkin deleted the dkoshkin/fix-containerd-restart branch February 16, 2024 02:12
@github-actions github-actions bot mentioned this pull request Feb 16, 2024
dkoshkin pushed a commit that referenced this pull request Feb 16, 2024
🤖 I have created a release *beep* *boop*
---


## 0.4.4 (2024-02-16)

<!-- Release notes generated using configuration in .github/release.yaml
at main -->

## What's Changed
### Fixes 🔧
* fix: restart Containerd when setting mirror config by @dkoshkin in
#374


**Full Changelog**:
v0.4.3...v0.4.4

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant