feat: add helm chart field #497
Conversation
faiq
force-pushed
the
faiq/new-helm-repo
branch
from
dd8f1a3 to
89af502
Compare
| @@ -46,6 +48,10 @@ func (Addons) VariableSchema() clusterv1.VariableSchema { | |||
| Description: "Cluster configuration", | |||
| Type: "object", | |||
| Properties: map[string]clusterv1.JSONSchemaProps{ | |||
| "helmChartRepository": { | |||
| Pattern: patterns.HostAndOptionalPort, | |||
| Description: "Optional OCI registry used to pull helm charts for adons", | |||
There was a problem hiding this comment.
Is this just an OCI registry or could it also be https helm repository somewhere?
There was a problem hiding this comment.
You could expand this description and add example too via Example property.
There was a problem hiding this comment.
I'm not sure what the difference between helm repository and OCI registry is. That entity would need to host all of the charts though. because the repository field for each addon gets set to this value.
There was a problem hiding this comment.
Helm repositories used to be supported only accessible via https. OCi support was later introduced meaning charts could be stored and referenced from OCI registries. The only difference is the scheme in the repository URL, using oci:// instead of https://. I think we should support both here.
There was a problem hiding this comment.
I don't know if all the users are going to be able to push helm charts to a single helm repository im also not sure how to validate it?
There was a problem hiding this comment.
This looks like it's only supporting pulling from one helm repository though right for all Helm addons?
There was a problem hiding this comment.
yeah, exactly the idea is that this source will have all of the helm charts the user needs
adds a helm chart field for customers who use a private OCI registry
this closes d2iq-labs#39