ci: Run Nutanix provider e2e tests on self-hosted runner #755
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
force-pushed
the
jimmi/self-hosted-gh-inputs
branch
from
5e3461e
to
2e7328a
Compare
jimmidyson
force-pushed
the
jimmi/self-hosted-gh-inputs
branch
2 times, most recently
from
23ddfaf
to
4590e64
Compare
jimmidyson
force-pushed
the
jimmi/self-hosted-gh-inputs
branch
3 times, most recently
from
87cd1a3
to
4cd1426
Compare
jimmidyson
force-pushed
the
jimmi/fix-up-e2e
branch
from
8962ce3
to
83ea6ad
Compare
|
This PR/issue depends on:
|
jimmidyson
force-pushed
the
jimmi/self-hosted-gh-inputs
branch
from
4cd1426
to
5cc0137
Compare
thunderboltsid
force-pushed
the
jimmi/self-hosted-gh-inputs
branch
from
5cc0137
to
f4c9319
Compare
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
thunderboltsid
force-pushed
the
jimmi/self-hosted-gh-inputs
branch
2 times, most recently
from
e6d23e3
to
79ec50d
Compare
jimmidyson
commented
Jun 27, 2024
thunderboltsid
force-pushed
the
jimmi/self-hosted-gh-inputs
branch
3 times, most recently
from
5307133
to
ba3d657
Compare
jimmidyson
commented
Jul 1, 2024
hack/examples/overlays/clusters/nutanix/calico/crs/kustomization.yaml.tmpl
Outdated
Show resolved
Hide resolved
dkoshkin
approved these changes
Jul 2, 2024
jimmidyson
commented
Jul 2, 2024
jimmidyson
commented
Jul 2, 2024
jimmidyson
commented
Jul 2, 2024
This is necessary as we want some e2e jobs to run on hosted runners and some to run on self-hosted runners. The actions runner controller does not support using multiple labels to target the runners See: https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/using-actions-runner-controller-runners-in-a-workflow#using-runner-scale-set-names
artifacts should be redacted regardless of success/failure of test.
We have seen instances where the controlplane endpoint is empty and then tests fail down the line. It's better to catch that early on and fail fast.
CAREN image is not pushed to a registry during build process. This causes failures on the clusterctl move step where image is not available in the workload cluster. We will in future push an image out to a registry and unskip this.
change conditional from provider:nutanix to runs-on:self-hosted-ncn-dind
thunderboltsid
force-pushed
the
jimmi/self-hosted-gh-inputs
branch
from
e4f1312
to
ac25738
Compare
mhrabovcin
approved these changes
Jul 2, 2024
Merged
This was referenced Jul 3, 2024
jimmidyson
pushed a commit
that referenced
this pull request
Jul 3, 2024
**What problem does this PR solve?**: Implements a wait for a check to pass against a typed object. We'll use this in some lifecycle handers, e.g., in a future change for deploying ServiceLoadBalancer configuration to the remote cluster. (This is a copy of #762. I had to close that after #755 added required checks that can't be run from PRs from public forks. ) **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
dlipovetsky
added a commit
that referenced
this pull request
Jul 3, 2024
**What problem does this PR solve?**:
This adds an optional configuration for the ServiceLoadBalancer Addon,
consisting of one or more IPv4 address ranges, e.g.,
```yaml
apiVersion: cluster.x-k8s.io/v1beta1
kind: Cluster
metadata:
name: <NAME>
spec:
topology:
variables:
- name: clusterConfig
value:
addons:
serviceLoadBalancer:
provider: MetalLB
configuration:
addressRanges:
- start: 10.100.1.1
end: 10.100.1.20
- start: 10.100.1.51
end: 10.100.1.70
```
(This is a copy of
#763.
I had to close that after
#755
added required checks that can't be run from PRs from public forks. )
**Which issue(s) this PR fixes**:
Fixes #
**How Has This Been Tested?**:
<!--
Please describe the tests that you ran to verify your changes.
Provide output from the tests and any manual steps needed to replicate
the tests.
-->
**Special notes for your reviewer**:
<!--
Use this to provide any additional information to the reviewers.
This may include:
- Best way to review the PR.
- Where the author wants the most review attention on.
- etc.
-->
dkoshkin
pushed a commit
that referenced
this pull request
Jul 5, 2024
🤖 I have created a release *beep* *boop* --- ## 0.12.0 (2024-07-05) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Add waiter for object by @dlipovetsky in #777 * feat: Define ServiceLoadBalancer Configuration API by @dlipovetsky in #778 * feat: Use HelmAddon as default addon strategy by @jimmidyson in #771 * feat: Apply MetalLB configuration to remote cluster by @dlipovetsky in #783 * feat: Update addon versions by @jimmidyson in #785 ### Fixes 🔧 * fix: Copy ClusterClasses and Templates without their owner references by @dlipovetsky in #776 * fix: Namespacesync controller should reconcile an updated namespace by @dlipovetsky in #775 * fix: use minimal image when deploying nfd chart by @faiq in #774 ### Other Changes * build: Update release metadata.yaml by @jimmidyson in #768 * ci: Run Nutanix provider e2e tests on self-hosted runner by @jimmidyson in #755 * build: Fix devbox run errors due to piped commands by @jimmidyson in #773 * ci: Fix ct check by @jimmidyson in #779 * build: Use go 1.22.5 toolchain to fix CVE by @jimmidyson in #780 * test(e2e): Use mesosphere fork v1.7.3-d2iq.1 for CAPI providers by @jimmidyson in #781 * ci: Move govulncheck to nightly and push to main triggers by @jimmidyson in #782 * ci: Disable nix cache on self-hosted runners by @jimmidyson in #786 **Full Changelog**: v0.11.2...v0.12.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Modify e2e workflow to Run Nutanix jobs on self-hosted-github runner
This is necessary as we want some e2e jobs to run on hosted runners
and some to run on self-hosted runners. The actions runner controller
does not support using multiple labels to target the runners
See: https://docs.github.com/en/actions/hosting-your-own-runners/managing-self-hosted-runners-with-actions-runner-controller/using-actions-runner-controller-runners-in-a-workflow#using-runner-scale-set-names
Depends on #754.