feat: Add waiter for object #762
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a wait for a check to pass against a typed object.
dlipovetsky
force-pushed
the
object-waiter
branch
from
a340159
to
3c78f08
Compare
dkoshkin
approved these changes
Jun 28, 2024
jimmidyson
reviewed
Jun 29, 2024
jimmidyson
reviewed
Jun 29, 2024
- Retry get only if object is not found, fail immediately otherwise.
jimmidyson
approved these changes
Jul 2, 2024
faiq
approved these changes
Jul 2, 2024
|
Replaced by #777 because this is from a public fork, and can't run some of the required checks. |
jimmidyson
pushed a commit
that referenced
this pull request
Jul 3, 2024
**What problem does this PR solve?**: Implements a wait for a check to pass against a typed object. We'll use this in some lifecycle handers, e.g., in a future change for deploying ServiceLoadBalancer configuration to the remote cluster. (This is a copy of #762. I had to close that after #755 added required checks that can't be run from PRs from public forks. ) **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Implements a wait for a check to pass against a typed object.
We'll use this in some lifecycle handers, e.g., in a future change for deploying ServiceLoadBalancer configuration to the remote cluster.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: