feat: Extract CAAPH values templates to files #809
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jimmidyson
force-pushed
the
jimmi/helm-values-include
branch
from
c281212
to
ae521bd
Compare
faiq
reviewed
Jul 17, 2024
Comment on lines
14
to
18
| {{ "{{" }} $k8sMinorVersionToCCMVersion := dict | ||
| {{ range $k8sVersion, $ccmVersion := .Values.hooks.ccm.aws.k8sMinorVersionToCCMVersion -}} | ||
| "{{ $k8sVersion }}" "{{ $ccmVersion }}" | ||
| {{ end -}} | ||
| {{ "}}" }} |
There was a problem hiding this comment.
No that is still required as it is configured by Helm template from Helm values. If you render the whole template you'll see why it's needed.
There was a problem hiding this comment.
Can it be placed in the file as well?
There was a problem hiding this comment.
No because it is Helm templated, not an file to be included as-is.
This simplifies the Helm templating directives by not requiring
inception-style escaping of templating braces, e.g. `{{ "{{" }}``
which are very hard to read and can introduce bugs.
faiq
force-pushed
the
jimmi/helm-values-include
branch
from
ae521bd
to
8029525
Compare
|
closing this because the work is included in #819 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simplifies the Helm templating directives by not requiring
inception-style escaping of templating braces, e.g. `{{ "{{" }}``
which are very hard to read and can introduce bugs.