feat: Enable Hubble Relay in Cilium deployment via CAAPH #899
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Relay is required for network visibility of a cluster as a whole. See https://docs.cilium.io/en/stable/gettingstarted/hubble_intro/.
faiq
approved these changes
Sep 3, 2024
jimmidyson
approved these changes
Sep 4, 2024
jimmidyson
requested changes
Sep 4, 2024
...r-api-runtime-extensions-nutanix/templates/cni/cilium/manifests/helm-addon-installation.yaml
Outdated
Show resolved
Hide resolved
|
@dlipovetsky Please can you add a test to e2e to ensure the necessary hubble components are running? This will also help us know what to expect in-cluster when Hubble is enabled. |
jimmidyson
force-pushed
the
dlipovetsky/enable-cilium-hubble-relay
branch
from
4b1fbf5
to
5c90945
Compare
|
@dlipovetsky Force pushed after editing last commit message to pass gitlint. |
|
Added e2e test in 56a583c (while also taking the opportunity to tidy up "kube-system" consts). |
jimmidyson
approved these changes
Sep 5, 2024
mhrabovcin
approved these changes
Sep 5, 2024
jimmidyson
added a commit
that referenced
this pull request
Sep 12, 2024
Merged
dlipovetsky
pushed a commit
that referenced
this pull request
Sep 25, 2024
🤖 I have created a release *beep* *boop* --- ## 0.16.0 (2024-09-25) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: Build with go 1.23 by @jimmidyson in #889 * feat: Enable Hubble Relay in Cilium deployment via CAAPH by @dlipovetsky in #899 * feat: Extract CAAPH values templates to files by @jimmidyson in #896 * feat: Build with go 1.23.1 by @jimmidyson in #913 * feat: Support node taints per nodepool and control plane by @jimmidyson in #909 ### Fixes 🔧 * fix: Remove deprecated toleration for node-role.kubernetes.io/master by @jimmidyson in #895 * fix: Do not use digests for Cilium images by @jimmidyson in #901 ### Other Changes * test: Bump Kubernetes versions for tests by @jimmidyson in #893 * ci: images tool by @faiq in #822 * build: Include Calico images in image list by @jimmidyson in #903 * build: Use upstream packages again from upstream by @jimmidyson in #908 * ci(main): enable creating release-please PR from release branches by @supershal in #912 * docs: Enable dark mode, add Nutanix color, and header links by @jimmidyson in #915 **Full Changelog**: v0.15.0...v0.16.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
dlipovetsky
added a commit
that referenced
this pull request
Sep 27, 2024
**What problem does this PR solve?**: Relay is required for network visibility of a cluster as a whole. See https://docs.cilium.io/en/stable/gettingstarted/hubble_intro/. **Which issue(s) this PR fixes**: Fixes # **How Has This Been Tested?**: <!-- Please describe the tests that you ran to verify your changes. Provide output from the tests and any manual steps needed to replicate the tests. --> **Special notes for your reviewer**: <!-- Use this to provide any additional information to the reviewers. This may include: - Best way to review the PR. - Where the author wants the most review attention on. - etc. --> --------- Co-authored-by: Jimmi Dyson <jimmidyson@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Relay is required for network visibility of a cluster as a whole. See https://docs.cilium.io/en/stable/gettingstarted/hubble_intro/.
Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: