fix: bundle correct arch for the mindthegap binary #954
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dkoshkin
force-pushed
the
dkoshkin/fix-arm-mindthegap-image
branch
from
6a76eb3
to
f56a76a
Compare
supershal
approved these changes
Oct 29, 2024
faiq
requested changes
Oct 29, 2024
faiq
approved these changes
Oct 29, 2024
Merged
dkoshkin
added a commit
that referenced
this pull request
Oct 29, 2024
🤖 I have created a release *beep* *boop* --- ## 0.21.0 (2024-10-29) <!-- Release notes generated using configuration in .github/release.yaml at main --> ## What's Changed ### Exciting New Features 🎉 * feat: update Nutanix CSI to 3.1.0 by @dkoshkin in #956 ### Fixes 🔧 * fix: bundle correct arch for the mindthegap binary by @dkoshkin in #954 * fix: use correct securityContext for Alpine based helm-repository Pod by @dkoshkin in #955 **Full Changelog**: v0.20.0...v0.21.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?:
Latest changes broke the published arm build. The
mindthegapbinary frombundle_builderwill always beBUILDPLATFORM, but we want it to matchTARGETPLATFORM.Which issue(s) this PR fixes:
Fixes #
How Has This Been Tested?:
Special notes for your reviewer: