Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

implement delete and force source_image option #137

Merged
merged 1 commit into from
Aug 8, 2023
Merged

Conversation

tuxtof
Copy link
Contributor

@tuxtof tuxtof commented Aug 8, 2023

What this PR does / why we need it:

implement additional option for unitary management of each source_image

source_image_delete: allow to delete a downloaded image once build process is finished
source_image_force: allow to redownload a source_image even if they already exist in the library

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
Fixes #124

Special notes for your reviewer:

Please confirm that if this PR changes any image versions, then that's the sole change this PR makes.

Release note:

- implement delete and force source_image option

@tuxtof tuxtof added the enhancement New feature or request label Aug 8, 2023
@github-actions
Copy link

github-actions bot commented Aug 8, 2023

✅ None of your dependencies violate policy!

Copy link
Contributor

@wolfganghuse wolfganghuse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tuxtof tuxtof merged commit 3541b9d into main Aug 8, 2023
15 checks passed
@tuxtof tuxtof deleted the feat/source_image branch August 8, 2023 19:42
@ktinthecloud
Copy link

ktinthecloud commented Aug 9, 2023

@tuxtof - When will the new release be ready that includes this fix? Just wondering.

@tuxtof
Copy link
Contributor Author

tuxtof commented Aug 9, 2023

there is another bug we need to fix and once it will be done we can release
worst case i expect next week for a new release

@tuxtof
Copy link
Contributor Author

tuxtof commented Aug 10, 2023

Hello @ktinthecloud just release 0.8.0
i let you test and come back to us if needed

@ktinthecloud
Copy link

It's working as expected. Thanks @tuxtof!

@tuxtof
Copy link
Contributor Author

tuxtof commented Aug 11, 2023

Nice , thanks for the confirmation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow force download existing image
3 participants