-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Readme #29
Merged
Readme #29
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,35 @@ | ||
# Contributing | ||
|
||
## Bugs | ||
|
||
* Submit an issue on the [issues page](https://github.com/nutriverse/mwana/issues) | ||
|
||
## Code contributions | ||
|
||
* Fork this repository to your Github account | ||
|
||
* Clone your version on your account down to your machine from your account | ||
|
||
``` | ||
git clone https://github.com/<yourgithubusername>/mwana.git | ||
``` | ||
|
||
* Make sure to track progress upstream i.e., on our version of `mwana` | ||
at `nutriverse/mwana`, by doing | ||
|
||
``` | ||
git remote add upstream https://github.com/nutriverse/mwana.git | ||
``` | ||
|
||
* Before making changes make sure to pull changes in from `upstream` by doing | ||
either `git fetch upstream` then merge later or `git pull upstream` to fetch | ||
and merge in one step | ||
|
||
* Make your changes on a new feature branch | ||
|
||
* Please write a test or tests for your changes if they affect code and not just | ||
documentation | ||
|
||
* Push up changes to your account | ||
|
||
* Submit a pull request at `nutriverse/mwana` |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should revisit Douglas' role. If he reviews the package, then we should put him down as
rev
for reviewer. If he gives substantial feedback other than "looks great" or "I wish it can be better", then we can consider upgrading this role toctb
. For me, my criteria for a contributor is someone who provides at least one of the following:A PR that is accepted and merged will automatically merit a
ctb
role as code from that person will actually get incorporated onto the package and will show in the git commits and diffs. The first two above will require really determining the significance of the person's feedback and whether or not we used that feedback to change/edit the package.So, let us revisit this after you have shared/presented the package to him.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will be able to ascertain the type of his contribution once I share the link with him to review the documentation.I expect his reviews on the Vignettes, other than the function documentation per se. We can revisit this later.