minor cleanup

discovery/api/server/client/types.go

@@ -22,6 +22,8 @@ import "github.com/nuts-foundation/go-did/vc"
 
 // PresentationsResponse is the response for the GetPresentations endpoint.
 type PresentationsResponse struct {
-	Entries   map[string]vc.VerifiablePresentation `json:"entries"`
-	Timestamp int                                  `json:"timestamp"`
+	// Entries contains mappings from timestamp (as string) to a VerifiablePresentation.
+	Entries map[string]vc.VerifiablePresentation `json:"entries"`
+	// Timestamp is the timestamp of the latest entry. It's not a unix timestamp but a Lamport Clock.
+	Timestamp int `json:"timestamp"`
 }

discovery/module_test.go

@@ -275,8 +275,8 @@ func setupModule(t *testing.T, storageInstance storage.Engine, visitors ...func(
 	m.config = DefaultConfig()
 	require.NoError(t, m.Configure(core.TestServerConfig()))
 	httpClient := client.NewMockHTTPClient(ctrl)
-	httpClient.EXPECT().Get(gomock.Any(), testEndpointOther, gomock.Any()).Return(nil, 0, nil).AnyTimes()
-	httpClient.EXPECT().Get(gomock.Any(), testEndpointUSecase, gomock.Any()).Return(nil, 0, nil).AnyTimes()
+	httpClient.EXPECT().Get(gomock.Any(), "http://example.com/other", gomock.Any()).Return(nil, 0, nil).AnyTimes()
+	httpClient.EXPECT().Get(gomock.Any(), "http://example.com/usecase", gomock.Any()).Return(nil, 0, nil).AnyTimes()
 	m.httpClient = httpClient
 	m.allDefinitions = testDefinitions()
 	m.serverDefinitions = map[string]ServiceDefinition{

discovery/test.go

@@ -47,8 +47,6 @@ var vpBob vc.VerifiablePresentation
 var unsupportedDID did.DID
 
 var testServiceID = "usecase_v1"
-var testEndpointOther = "http://example.com/other"
-var testEndpointUSecase = "http://example.com/usecase"
 
 func testDefinitions() map[string]ServiceDefinition {
 	issuerPattern := "did:example:*"