Discovery: update client copy of Discovery Services #2718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reinkrul
force-pushed
the
discovery/update-clients
branch
from
627259c to
ce6ee81
Compare
reinkrul
force-pushed
the
discovery/update-clients
branch
from
e506d89 to
d669239
Compare
gerardsn
previously requested changes
Jan 11, 2024
discovery/cmd/cmd.go
Outdated
| @@ -33,5 +33,7 @@ func FlagSet() *pflag.FlagSet { | |||
| flagSet.StringSlice("discovery.server.definition_ids", defs.Server.DefinitionIDs, | |||
| "IDs of the Discovery Service Definitions for which to act as server. "+ | |||
| "If an ID does not map to a loaded service definition, the node will fail to start.") | |||
| flagSet.Duration("discovery.client.update_interval", defs.Client.UpdateInterval, "How often to check for Discovery Services updates, "+ | |||
There was a problem hiding this comment.
difference between this and registration_refresh_interval would be a lot clearer if description starts with the key difference. e.g., "(Re-)Publish at this interval" and "Fetch updates at this interval".
What if I renamed "registration" on the client-side "activation"? So XIS admin apps call |
woutslakhorst
requested changes
Jan 19, 2024
woutslakhorst
approved these changes
Jan 22, 2024
rolandgroen
added a commit
that referenced
this pull request
Jan 25, 2024
* master: (38 commits) VDR: Fix duplicate results when listing DIDs (#2743) VDR: API to list owned DIDs (#2742) VDR: Move did:nuts specific to did:nuts creator (#2735) Discovery: API to list configured Discovery Services (#2739) PKI: Adjust validation logging; OK = trace, NOK = info (#2736) Discovery: update client copy of Discovery Services (#2718) VDR: Group all DID Document management funcs in a new interface (#2737) Handle direct_post return from wallet to verifier (#2702) Bump github.com/nats-io/nats.go from 1.31.0 to 1.32.0 (#2724) Discovery: fix API of Client.Search() (#2730) Bump github.com/amacneil/dbmate/v2 from 2.10.0 to 2.11.0 (#2729) Discovery: DID registration by clients (#2709) Config: Add HTTP-client timeout (#2725) Policy: prevent nil dereference when no backend is configured (#2723) Bump github.com/nats-io/nats-server/v2 from 2.10.7 to 2.10.9 (#2721) SQL: specify lengths for VARCHAR columns to avoid different behavior with different RDBMS's (#2717) Bump golang from 1.21.5-alpine to 1.21.6-alpine (#2719) Handle authorization request from verifier by holder/wallet (#2680) Bump golang.org/x/crypto from 0.17.0 to 0.18.0 (#2716) Bump github.com/lestrrat-go/jwx/v2 from 2.0.18 to 2.0.19 (#2715) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Requires #2730