Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Statuslist: move all code to statuslist package #2804

Merged
merged 4 commits into from
Feb 19, 2024

Conversation

gerardsn
Copy link
Member

This PR just moves all code to one package for easy reviewing. Actual changes will be made in the next PR

Copy link
Member

@reinkrul reinkrul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely an improvement I think?

Did you get a lot of "Type name shouldn't start with package name" warnings? Would it be better to call the package statuslist2021 so you can shorten all type names? So;

  • ContextURI
  • Entry
  • Credential
  • etc

@gerardsn gerardsn requested a review from reinkrul February 19, 2024 09:20
@gerardsn gerardsn merged commit cbbc596 into master Feb 19, 2024
8 of 9 checks passed
@gerardsn gerardsn deleted the statuslist/move-all-code-one-package branch February 19, 2024 10:26
rolandgroen added a commit that referenced this pull request Feb 20, 2024
* master: (23 commits)
  Remove dead code (#2814)
  VDR: Resolve did:web from database first, then HTTP (#2808)
  Bump github.com/prometheus/client_model from 0.5.0 to 0.6.0 (#2811)
  Bump github.com/nats-io/nats.go from 1.33.0 to 1.33.1 (#2812)
  Bump gorm.io/driver/mysql from 1.5.2 to 1.5.4 (#2813)
  Bump github.com/nats-io/nats-server/v2 from 2.10.10 to 2.10.11 (#2803)
  remove credential.validationError (#2807)
  move test credentials to test package and replace structs with maps (#2805)
  Statuslist: move all code to statuslist package (#2804)
  Support MySql (#2801)
  Add JAR/RFC9101 to authorization requests (#2783)
  Bump google.golang.org/grpc from 1.61.0 to 1.61.1 (#2796)
  Bump github.com/nats-io/nats.go from 1.32.0 to 1.33.0 (#2797)
  Discovery: improve test stability (#2795)
  StatusList: replace memstore with sqlstore (#2784)
  StatusList: issuance (#2738)
  StatusList2021: change encoding to not use padding (#2793)
  Bump github.com/amacneil/dbmate/v2 from 2.11.0 to 2.12.0 (#2792)
  Bump github.com/hashicorp/vault/api from 1.11.0 to 1.12.0 (#2791)
  VDR: Allow deactivation for did:web, added support to v2 API (#2776)
  ...

# Conflicts:
#	auth/api/iam/api.go
#	auth/api/iam/openid4vp_test.go
#	codegen/configs/auth_iam.yaml
#	docs/_static/auth/iam.yaml
#	vcr/holder/mock.go
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants