Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code cleanup #3083

Merged
merged 5 commits into from
May 6, 2024
Merged

Code cleanup #3083

merged 5 commits into from
May 6, 2024

Conversation

reinkrul
Copy link
Member

@reinkrul reinkrul commented May 3, 2024

Fixes #2966

Only thing left is to upgrade the JWT middleware:

http/engine.go:224:18: SA1019: middleware.JWTWithConfig is deprecated: Please use https://github.com/labstack/echo-jwt instead (staticcheck)
                echoServer.Use(middleware.JWTWithConfig(middleware.JWTConfig{

@reinkrul reinkrul requested a review from gerardsn May 3, 2024 12:04
auth/api/iam/types.go Show resolved Hide resolved
.golangci.yml Show resolved Hide resolved
@reinkrul reinkrul requested a review from gerardsn May 3, 2024 13:39
@reinkrul reinkrul merged commit e87ee89 into master May 6, 2024
8 of 9 checks passed
@reinkrul reinkrul deleted the code-cleanup branch May 6, 2024 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use linters to check our codebase
2 participants