-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crypto: Support Azure Key Vault #3128
Conversation
3b17fa3
to
511923c
Compare
8951009
to
4da23b0
Compare
@woutslakhorst can you review this? My main concern is that we need to provide Azure Key Vault with a key name, for which I chose to use the verification method's key ID. But, Azure Key Vault only allows But, if we want to support creating keys in key storage that require the key thumbprint (e.g. I also checked if we can rename the key in Key Vault, but that's not possible. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
just a comment on the panic comment
d1c101c
to
1df084b
Compare
Uses: