Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

VCR: Remove @context default value from OAS #3177

Merged
merged 4 commits into from
Jun 11, 2024

Conversation

reinkrul
Copy link
Member

@reinkrul reinkrul commented Jun 8, 2024

It breaks code generation in Java. Can be safely deleted, we don't necerassily need it.

@reinkrul reinkrul requested review from gerardsn and woutslakhorst and removed request for gerardsn June 8, 2024 06:31
Copy link
Member

@gerardsn gerardsn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add to description that it is the default to prevent magic behavior

@reinkrul
Copy link
Member Author

add to description that it is the default to prevent magic behavior

It's already there:

If omitted, the "https://nuts.nl/credentials/v1" context is used.

@reinkrul reinkrul requested a review from gerardsn June 10, 2024 10:21
@reinkrul reinkrul merged commit 36d4527 into master Jun 11, 2024
9 checks passed
@reinkrul reinkrul deleted the vcr/oas-remove-context-default branch June 11, 2024 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants