Prepare DID storage for multiple DIDs per DID Subject #3196
Conversation
- removed tenant option for did:web - moved sql storage from did:web to global
vdr/didweb/manager.go
Outdated
| Subject: newDID.String(), | ||
| } | ||
| var doc *sql.DIDDocument | ||
| if doc, err = documentStore.CreateOrUpdate(sqlDid, []sql.SqlVerificationMethod{{ |
There was a problem hiding this comment.
You're not really creating a new DID document here? You could have multiple DIDs (even multiple did:web's?) belonging to the same subject, which should then all return the same services and VMs?
There was a problem hiding this comment.
True, but I wanted this PR to just update the DB model. In a later PR we'll move this logic one level higher (so the web manager will no longer have a create just a read/list/resolve)
| } | ||
|
|
||
| // SqlDIDManager is the implementation of the DIDManager interface | ||
| type SqlDIDManager struct { |
There was a problem hiding this comment.
already in sql package, so no need to prepend types with Sql
There was a problem hiding this comment.
true, but DIDManager is the interface. When declaring vars from other packages you should use the interface. We won't see var a sql.SqlDIDManager anywhere. Also I'm not sure the package will not be renamed after some refactors.
Use the DB as primary and (for now) the network update as side-effect (maybe within the sql transaction) |
Co-authored-by: reinkrul <info@reinkrul.nl>
Co-authored-by: reinkrul <info@reinkrul.nl>
Co-authored-by: reinkrul <info@reinkrul.nl>
closes #3193