Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Auth v2: allow additional credentials in RequestServiceAccessToken #3206

Merged
merged 4 commits into from
Jun 24, 2024
Merged

Auth v2: allow additional credentials in RequestServiceAccessToken #3206

merged 4 commits into from
Jun 24, 2024

Conversation

reinkrul
Copy link
Member

@reinkrul reinkrul commented Jun 21, 2024 •
edited
Loading

Fixes #3198

TODO:

  • Document usage somewhere with a real-world example
  • End-to-end test

@reinkrul reinkrul requested a review from woutslakhorst June 21, 2024 15:07
woutslakhorst
woutslakhorst approved these changes Jun 24, 2024
View reviewed changes
e2e-tests/oauth-flow/rfc021/do-test.sh Outdated Show resolved Hide resolved
@reinkrul reinkrul merged commit c5686d7 into master Jun 24, 2024
9 checks passed
@reinkrul reinkrul deleted the auth/service-token-credential branch June 24, 2024 13:36
@reinkrul reinkrul mentioned this pull request Jun 25, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@woutslakhorst woutslakhorst woutslakhorst approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow passing of additional credentials to access token request and support holder claims
2 participants
@reinkrul @woutslakhorst