-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Auth: replace DID with subject in internal API endpoints #3277
Conversation
556795a
to
1c733aa
Compare
the random ordering might also impact the test results (random failures) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't you pass down the subject to the RFC021 request? The PD should be held against all wallets.
Can you describe how that works? What if the Authorization Server doesn't support |
metadata doesn't support it (yet) so it's a governance thing. Before requesting a VC issued to a certain did method in PEX, all members should have updated. |
Yes, but the PEX implementation (Submission Builder) and VP verification are all fixed to 1 DID now. Changing it to support multiple DIDs is going to take a lot of work, so best to do that later, and do the API changes first. Nothing breaks now, worst case credentials aren't found if the "didmethods" config order is off, but there aren't actual use cases that support those at this moment (e.g. KIK-v, eOverdracht or ANW starting to use |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think PD fulfillment needs to happen at a lower level. If we put it here now I think it will be a lot harder to fix later on
@reinkrul ping me when other PRs have been merged. |
@woutslakhorst ready for review |
TODO:
SubjectManager.List()
returns the DIDs in unspecified order, making it a guess which DID is actually used. So it should return them in preferred order (did:web
first): VDR: SubjectManager returns DIDs in preferred order #3291Requires: