Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go 1.23 #3311

Merged
merged 3 commits into from
Sep 17, 2024
Merged

Update to go 1.23 #3311

merged 3 commits into from
Sep 17, 2024

Conversation

gerardsn
Copy link
Member

@gerardsn gerardsn commented Aug 19, 2024

@gerardsn gerardsn mentioned this pull request Aug 19, 2024
@gerardsn
Copy link
Member Author

the failing e2e test seems to be a timing issue as I can only reproduce it about 50% of the time locally

@reinkrul
Copy link
Member

@gerardsn
Copy link
Member Author

gerardsn commented Sep 6, 2024

https://pkg.go.dev/crypto/x509#ParseCertificate

Before Go 1.23, ParseCertificate accepted certificates with negative serial numbers. This behavior can be restored by including "x509negativeserial=1" in the GODEBUG environment variable.

need to investigate if pkiO issues certs with negative serials

@gerardsn
Copy link
Member Author

gerardsn commented Sep 11, 2024

pkiO certificates use serialnumbers > 0, so they are not impacted by this change

from https://cp.pkioverheid.nl/pkioverheid-por-v5.0.html

7.1.2.3.2 serialNumber
All subscriber certificates SHALL have a serialNumber field. This field SHALL have a value meeting the following requirements:

it SHALL be be greater than zero (0), and
...

@gerardsn gerardsn merged commit 4dd24c1 into master Sep 17, 2024
8 of 9 checks passed
@gerardsn gerardsn deleted the golang-1.23 branch September 17, 2024 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants